Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON exports #344
JSON exports #344
Changes from all commits
9a3a9d4
fd30305
d7c8c65
6c33f6a
ebf900e
fe75f98
256e30b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be changed? I have not run test, but I never changed the default. I wonder if it will introduce subtle regressions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK, it fails on me with just
dev
. from what I understand setuptools does not supportdev
as a valid version nameThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing it from "dev" to "0.dev" did not have a noticeable effect in my setup. Thus, I'm fine with changing it.
I assume, it comes from some semantic versioning naming conventions, which require it to start with an integer. "0.devN" seems more common.
I wonder if it is also related to the README?
whotracks.me/README.md
Line 121 in ebe5b85
whotracks.me/README.md
Line 145 in ebe5b85
But the commands from the README still seem to work for me.