Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch mode select all #482

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Batch mode select all #482

wants to merge 4 commits into from

Conversation

TheTacoScott
Copy link

No description provided.

@TheTacoScott TheTacoScott mentioned this pull request Jul 14, 2020
Closed
@TheTacoScott
Copy link
Author

newest commit uses the correct array for select all

@whyboris
Copy link
Owner

Sorry I've not yet merged #464 which does the "Select all showing" -- I'll be able to reconcile the two PRs myself 👌
I'll try to look at what you have this weekend - I've been spending time on getting version 3.0.0 into a mostly-working shape 😅

I'm eager to see what you came up with "batch tag edit mode and normal mode" 👀

😁 🤝 😁

@whyboris whyboris changed the base branch from master to main July 26, 2020 20:08
whyboris
whyboris reviewed Jul 26, 2020
View reviewed changes
src/app/components/home.component.ts
@@ -135,6 +135,7 @@ export class HomeComponent implements OnInit, AfterViewInit {
versionNumber = globals.version;

public finalArray: ImageElement[] = [];
public selectedCount: number;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of selectedCount -- are you thinking of using it somewhere in the template (to show to the user?)

@whyboris
Copy link
Owner

whyboris commented Jul 26, 2020 •
edited
Loading

Thank you @TheTacoScott for the PR -- I've now merged my VHA 3.0.0 work and renamed master to main
I've also merged in #464 which does the same thing as this PR.
I think you have a nice idea with the "number selected" -- maybe worth showing it in the template 👍 so users know how many they selected!

Could you pull in the latest main and reconcile the duplicate functionality (e.g. selectAll vs your selectAllShowing which is identical) 🤝

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyboris whyboris whyboris left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheTacoScott @whyboris