Feature/animated-sleeping #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @exincore! Thanks for the PR! I need some time to review the PR. |
exincore
commented
Mar 15, 2022
exincore
commented
Mar 15, 2022
exincore
commented
Mar 15, 2022
exincore
commented
Mar 15, 2022
|
Please, fix conflicts and I will merge the PR |
Closed
|
Closed by mistake, reopening... |
|
Goodness, this will take a while to merge/rebase |
exincore
force-pushed
the
feature/animated-sleeping
branch
from
00d41f8 to
3ad777f
Compare
|
@win0err I will clean up the idle sprites, but other than that, this feature is ready for re-review. Note that the animation state machine previously implemented in this feature is now removed. |
* Update translations
exincore
commented
Oct 26, 2022
| @@ -47,47 +47,51 @@ msgid "Idle threshold" | |||
| msgstr "Порог бездействия" | |||
|
|
|||
| #: src/resources/ui/preferences.ui:34 | |||
| msgid "Idle animation" | |||
| msgstr "" | |||
win0err
reviewed
Oct 29, 2022
po/messages.pot
Outdated
| @@ -46,45 +46,49 @@ msgid "Idle threshold" | |||
| msgstr "" | |||
|
|
|||
| #: src/resources/ui/preferences.ui:34 | |||
| msgid "Idle animation" | |||
There was a problem hiding this comment.
Wouldn't it be better to call it "Animated idle"?
There was a problem hiding this comment.
I decided on Idle animation due to the presence of Idle threshold, however I will go ahead and rename everything. It can be reverted later.
|
LGTM. Great work, thank you! |
win0err
pushed a commit
that referenced
this pull request
Mar 15, 2023
The cat has a sleeping animation now
win0err
pushed a commit
that referenced
this pull request
Mar 16, 2023
The cat has a sleeping animation now
win0err
pushed a commit
that referenced
this pull request
Mar 26, 2023
The cat has a sleeping animation now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animated Sleeping
What?
Why?
How?
panelMenuButton.jslooks for and loads sprites into arrays based on their name likeactive-0oridle-3etc.prefs.jset al. has a toggle button for reverting back to non-animated sleepingmy-sleeping-symbolic.svg(contains cute snoozing)