-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log errors at ffi boundary [WPB-14355] #861
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
==========================================
+ Coverage 75.94% 76.20% +0.26%
==========================================
Files 113 113
Lines 20651 20688 +37
==========================================
+ Hits 15683 15766 +83
+ Misses 4968 4922 -46
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
We can't guarantee the method, format, consistency, or existence of logging of core-crypto error messages in FFI code. So we take the easy solution and generate a log message for every error just before it crosses that boundary.
8664fec
to
d5b496e
Compare
What's new in this PR
Adds a minor non-breaking feature which logs error messages just as they cross the FFI boundary.
PR Submission Checklist for internal contributors
SQPIT-764
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.