feat: set the correct cipher suite when claiming key packages #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly' into feat/set-the-correct-public-key-when-creating-MLS-conversation # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/MLSClientProvider.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
Datadog ReportBranch report: ✅ 0 Failed, 2883 Passed, 107 Skipped, 8m 57.04s Wall Time |
…correct-cipher-suite-when-claiming-key-packeges
MohamadJaara
changed the base branch from
release/android-cycle-4.6
to
fix/fetch-MLS-config-when-not-avilable-locally
…-config-when-not-avilable-locally
…correct-cipher-suite-when-claiming-key-packeges # Conflicts: # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/CoreCryptoCentral.kt # logic/src/commonJvmAndroid/kotlin/com/wire/kalium/logic/CoreCryptoExceptionMapper.kt
…S-config-when-not-avilable-locally
Signed-off-by: MohamadJaara <[email protected]>
…ly' into feat/set-the-correct-public-key-when-creating-MLS-conversation # Conflicts: # gradle/libs.versions.toml
…ly' into feat/set-the-correct-public-key-when-creating-MLS-conversation
MohamadJaara
changed the base branch from
fix/fetch-MLS-config-when-not-avilable-locally
to
feat/set-the-correct-public-key-when-creating-MLS-conversation
…g-MLS-conversation' into feat/set-the-correct-cipher-suite-when-claiming-key-packeges # Conflicts: # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/CoreCryptoCentral.kt # cryptography/src/jvmTest/kotlin/com/wire/kalium/cryptography/BaseProteusClientTest.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/client/E2EIClientProviderTest.kt
ohassine
approved these changes
May 7, 2024
Base automatically changed from
feat/set-the-correct-public-key-when-creating-MLS-conversation
to
release/android-cycle-4.6
May 7, 2024 10:03
…-correct-cipher-suite-when-claiming-key-packeges # Conflicts: # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/MLSClientImpl.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepository.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/mlspublickeys/MLSPublicKeysMapper.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/mlspublickeys/MLSPublicKeysRepository.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/client/E2EIClientProviderTest.kt
MohamadJaara
deleted the
feat/set-the-correct-cipher-suite-when-claiming-key-packeges
branch
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Claims key packages does not set the correct cipher suite to the backend
Solutions
set the correct cipher suite when claiming key packages
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.