Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade gradle wrapper to match gradle version [WPB-10569] #2972

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Aug 28, 2024

TaskWPB-10569 [Android] publish fdroid


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

missing distributionSha256Sum
gradle vs wrapper version mismatch

Solutions

run

./gradlew wrapper --gradle-version 8.8 \
  --gradle-distribution-sha256-sum f8b4f4772d302c8ff580bc40d0f56e715de69b163546944f787c87abf209c961

to fix it

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title chore: upgrade gradle wrapper to match gradle version chore: upgrade gradle wrapper to match gradle version [WPB-10569] Aug 28, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Aug 28, 2024
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

Comment on lines +147 to +149
tasks.wrapper {
distributionType = Wrapper.DistributionType.ALL
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is added to force ./gradle wrapper ... to set all as distribution type

@MohamadJaara MohamadJaara enabled auto-merge August 28, 2024 07:05
@MohamadJaara MohamadJaara added echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. and removed echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. labels Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

Test Results

3 180 tests  ±0   3 075 ✔️ ±0   3m 48s ⏱️ -11s
   545 suites ±0      105 💤 ±0 
   545 files   ±0          0 ±0 

Results for commit ee9e511. ± Comparison against base commit 851aff7.

♻️ This comment has been updated with latest results.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Aug 28, 2024
Copy link

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 28, 2024

Datadog Report

Branch report: chore/update-gradle-wrapper
Commit report: fe6f300
Test service: kalium-jvm

✅ 0 Failed, 3075 Passed, 105 Skipped, 14.02s Total Time

@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 28, 2024
Merged via the queue into release/candidate with commit 501b813 Aug 28, 2024
22 checks passed
@MohamadJaara MohamadJaara deleted the chore/update-gradle-wrapper branch August 28, 2024 08:00
github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
)

* chore: upgrade gradle wrapper to match gradle version

* force -all

* revert unwanted changes
MohamadJaara added a commit that referenced this pull request Aug 28, 2024
)

* chore: upgrade gradle wrapper to match gradle version

* force -all

* revert unwanted changes

(cherry picked from commit 501b813)
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2024
) (#2973)

* chore: upgrade gradle wrapper to match gradle version

* force -all

* revert unwanted changes

Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. 👕 size: L type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants