-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: messages migration from proteus to mls [WPB-15149] #3218
Conversation
Quality Gate passedIssues Measures |
persistence/src/commonTest/kotlin/com/wire/kalium/persistence/utils/stubs/MessageStubs.kt
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 3239 Passed, 108 Skipped, 1m 3.04s Total Time New Flaky Tests (1)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3218 +/- ##
=====================================================
+ Coverage 54.17% 54.51% +0.33%
=====================================================
Files 1250 1250
Lines 36514 36520 +6
Branches 3696 3696
=====================================================
+ Hits 19783 19908 +125
+ Misses 15304 15213 -91
+ Partials 1427 1399 -28
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When moving messages from proteus conversation to MLS if some message contained reactions or
RestrictedAsset
then migration failed causing slow sync to break.Solutions
Migrate
MessageRestrictedAssetContent
andReaction
tables to update on cascade whenMessage
is changingconversation_id
Testing
Test Coverage (Optional)
How to Test
Attachments (Optional)