feat: Clear conversation content on all devices WPB-14938

[borichellow]

WPB-14938 [Android] Add "Delete group and content on all devices" option when leaving a group

What's new in this PR?

1. aligned all the "ClearContent" and "DeleteConversation" useCases to to re-use each other when needed instead of calling repository directly.
2. updated ClearConversationContentUseCase to send a signal message with properly set needToRemoveLocally field which indicates when other clients should not just clear the content but fully remove the conversation.
3. fixed ClearConversationContentHandler it was working wrong.
4. added conversation to remove queue (save it in MetaDataDAO) for the case when event with MessageContent.Cleared comes before "UserLeft" event: we save ConversationId and check that queue in MemberLeaveEventHandler if self user left the conversation and that conversation is in queue to remove - delete the conversation.
5. updated tests

[github-actions]

Test Results

3 408 tests  +3   3 300 ✅ +3   5m 29s ⏱️ -1s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit dd3590a. ± Comparison against base commit c6d3335.

This pull request removes 7 and adds 10 tests. Note that renamed tests count towards both.

com.wire.kalium.logic.feature.conversation.DeleteConversationLocallyUseCaseTest ‑ givenDeleteLocalConversationInvoked_whenAssetClearIsUnsuccessful_thenErrorResultIsPropagated[jvm]
com.wire.kalium.logic.feature.conversation.DeleteConversationLocallyUseCaseTest ‑ givenDeleteLocalConversationInvoked_whenContentClearIsUnsuccessful_thenErrorResultIsPropagated[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromOtherClient_whenMessageDoesNotNeedToBeRemovedAndUserIsNotPartOfConversation_thenContentNorConversationShouldBeRemoved[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromOtherClient_whenMessageDoesNotNeedToBeRemovedAndUserIsPartOfConversation_thenContentShouldBeRemoved[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromOtherClient_whenMessageNeedsToBeRemovedLocallyAndUserIsNotPartOfConversation_thenWholeConversationShouldBeDeleted[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromOtherClient_whenMessageNeedsToBeRemovedLocallyAndUserIsPartOfConversation_thenOnlyContentShouldBeCleared[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromTheSameClient_whenHandleIsInvoked_thenContentNorConversationShouldBeRemoved[jvm]

com.wire.kalium.logic.feature.conversation.ClearConversationContentUseCaseTest ‑ givenClearAssetsFails_whenInvoking_thenCorrectlyPropagateFailure[jvm]
com.wire.kalium.logic.feature.conversation.DeleteConversationLocallyUseCaseTest ‑ givenDeleteLocalConversationInvoked_whenClearContentIsUnsuccessful_thenErrorResultIsPropagated[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromOtherClient_whenMessageInSelfConversation_thenDoNothing[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromOtherUserAndNeedToRemove_whenMessageNotInSelfConversation_thenWholeConversationShouldNotBeDeleted[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromOtherUser_whenMessageNotInSelfConversationAndNoNeedToRemove_thenOnlyClearContent[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromTheSelfUser_whenMessageInSelfConversationAndNoNeedToRemove_thenOnlyContentRemoved[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenMessageFromTheSelfUser_whenMessageNotInSelfConversation_thenContentNorConversationShouldBeRemoved[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenSelfSenderAndMessageInSelfConversation_whenNeedToRemoveAndConversationIsNotLeftYet_thenContentCleared[jvm]
com.wire.kalium.logic.sync.receiver.conversation.ClearConversationContentHandlerTest ‑ givenSelfSenderAndMessageInSelfConversation_whenNeedToRemoveAndLeftConversation_thenContentAndConversationRemoved[jvm]
com.wire.kalium.logic.sync.receiver.conversation.MemberLeaveEventHandlerTest ‑ givenDaoReturnsSuccessAndConversationInDeleteQueue_whenDeletingSelfMember_thenConversationDeleted[jvm]

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	feat/clear_conversation_content_on_all_devices
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	microseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	677.02
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	324,730.84
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,338,847.25
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,851.37

🐰 View full continuous benchmarking report in Bencher

[datadog-wireapp]

Datadog Report

Branch report: feat/clear_conversation_content_on_all_devices
Commit report: ce6774d
Test service: kalium-jvm

✅ 0 Failed, 3300 Passed, 108 Skipped, 1m 2.36s Total Time

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 64.21053% with 34 lines in your changes missing coverage. Please review.

Project coverage is 54.43%. Comparing base (c6d3335) to head (dd3590a).

Files with missing lines	Patch %	Lines
.../logic/data/conversation/ConversationRepository.kt	4.16%	23 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt	0.00%	8 Missing ⚠️
...c/receiver/conversation/MemberLeaveEventHandler.kt	86.66%	0 Missing and 2 partials ⚠️
...re/conversation/ClearConversationContentUseCase.kt	96.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3235      +/-   ##
===========================================
- Coverage    54.44%   54.43%   -0.02%     
===========================================
  Files         1271     1271              
  Lines        37018    37062      +44     
  Branches      3753     3764      +11     
===========================================
+ Hits         20156    20174      +18     
- Misses       15445    15468      +23     
- Partials      1417     1420       +3     

Files with missing lines	Coverage Δ
...e/conversation/DeleteConversationLocallyUseCase.kt	100.00% <100.00%> (ø)
...eceiver/handler/ClearConversationContentHandler.kt	100.00% <100.00%> (ø)
...re/conversation/ClearConversationContentUseCase.kt	96.77% <96.00%> (-3.23%)	⬇️
...c/receiver/conversation/MemberLeaveEventHandler.kt	93.93% <86.66%> (-2.62%)	⬇️
...um/logic/feature/conversation/ConversationScope.kt	0.00% <0.00%> (ø)
.../logic/data/conversation/ConversationRepository.kt	59.43% <4.16%> (-2.26%)	⬇️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d3335...dd3590a. Read the comment docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[datadog-wireapp]

Datadog Report

Branch report: feat/clear_conversation_content_on_all_devices
Commit report: cedd3ef
Test service: kalium-jvm

✅ 0 Failed, 3300 Passed, 108 Skipped, 59.25s Total Time