Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API access): Update API from v2 to v5 and add API Version as env #35

Conversation

LennardZieglerCONPORT
Copy link
Collaborator


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The currently used Wire-API version is v2. Needed to be changed to v5.

Solutions

Added new environment variable to quickly change the API version in future issues. Used this variable to specify which API version to access.

Testing

How to Test

Check the network tab in the dev-tools to verify the selected API version.


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


kevin.jaroschewski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LennardZieglerCONPORT LennardZieglerCONPORT marked this pull request as ready for review June 26, 2024 08:22
@LennardZieglerCONPORT LennardZieglerCONPORT merged commit d008b61 into staging Jun 26, 2024
4 of 5 checks passed
@LennardZieglerCONPORT LennardZieglerCONPORT deleted the kj/wir-12-switch-from-wire-api-v2-to-wire-api-v5 branch June 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants