Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide search button in group conversation user profile [WPB-5656] #2475

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix: hide search button in group conversation user profile [WPB-5656] #2475

merged 2 commits into from
Nov 27, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Nov 27, 2023 •
edited by github-actions bot
Loading

BugWPB-5656 [Android][Search] Hide search button when entering user profile from Group Participants

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • fixed showing search button when opening user profile from group details (it will check if state contains groupInfo)

@github-actions GitHub Actions
Copy link
Contributor

Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4fed341.

@tmspzz tmspzz enabled auto-merge (squash) November 27, 2023 13:20
@tmspzz tmspzz merged commit 27328c5 into release/candidate Nov 27, 2023
8 checks passed
@tmspzz tmspzz deleted the fix/hide-search-group-conv-user-profile branch November 27, 2023 13:34
@AndroidBob AndroidBob mentioned this pull request Nov 27, 2023
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2040 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@tmspzz tmspzz tmspzz approved these changes

@alexandreferris alexandreferris Awaiting requested review from alexandreferris

@ohassine ohassine Awaiting requested review from ohassine

Assignees

@Garzas Garzas

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garzas @AndroidBob @tmspzz @MohamadJaara @saleniuk