-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: applock toggle state when enforced and responding to changes [WPB-5751] #2564
fix: applock toggle state when enforced and responding to changes [WPB-5751] #2564
Conversation
Test Results702 tests 702 ✅ 8m 37s ⏱️ Results for commit 3499804. ♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2438 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2452 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2454 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Currently, the app lock toggle is visible with ON value but just disabled when the app lock is enforced by the team admin. According to the designs in that case the toggle should be hidden and only "ON" text should be visible.
Also when the user is on that screen and the team admin changes the setting, it doesn't get updated automatically but only after closing and opening it again.
Solutions
Change the appearance of the app lock row so that if it's enforced by the team admin then the toggle is not shown but just a text is visible.
Use the updated use case to observe the editable app lock value changes instead of getting just a single value.
Dependencies (Optional)
Needs releases with:
Testing
How to Test
Open settings screen and change the app lock team settings on team admin panel.
Attachments (Optional)
applock_toggle_changes.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.