Standalone module for creating a spend transaction #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
commented
Nov 30, 2023
darosior
force-pushed
the
2311_spend_mod
branch
from
a5b0a46 to
21237f5
Compare
This moves create_spend_internal in bulk. The interface is still inappropriate and will be adapted in the next commits.
This is a first step toward removing the database accesses from the spend PSBT creation helper. It now always take a change address, and return whether it used it. If it did the caller retrieves the information about the change address and if necessary bumps the next derivation index to use.
Instead, pass the address details, if known, as a parameter.
darosior
force-pushed
the
2311_spend_mod
branch
from
21237f5 to
f1d19f8
Compare
darosior
changed the title
|
Rebased after #816 merge. I think this is ready for review. This is a large diff but most of it is from the move in the first commit. |
This was referenced Dec 7, 2023
Merged
We introduce a trait to get the wallet transaction correponding to the transaction input in order to encapsulate the spend module.
It's basically free to do now, so we might as well do it.
Now that we have sweep capability no need to duplicate half the logic, just reuse the helper.
They aren't externally called anymore
It's not needed in spend anymore
It's already performed (twice) in spend::create_psbt()
We could use a trait but instead there is just a couple fields we need so simply copy them over.
They would be discarded immediately in the filter below.
Allows for a clearer interface: you explicitly set whether you are creating a replacement, and you don't have dangling 0s when you don't which necessitate a comment to explain what they correspond to.
darosior
force-pushed
the
2311_spend_mod
branch
from
f1d19f8 to
0f69411
Compare
|
Since it's only a refactoring and you only found typos, i'll go ahead and merge this. I want this (and other things based on this) to land in master to be tested by others. |
|
self-ACK 0f69411 |
darosior
added a commit
that referenced
this pull request
Dec 8, 2023
…and with a high number of candidates c002ab9 spend: scale down the number of BnB when not compiling with optimizations (Antoine Poinsot) f18086c spend: scale down the number of BnB rounds as number of candidates increases (Antoine Poinsot) Pull request description: Based on #842. Performing BnB with a large number of candidates can be computation expensive. Especially in debug mode. It can make the software lag in situations where it's called repeatedly. Reasonably scale down the number of rounds performed depending on the number of candidates and whether optimizations are enabled. Fixes #846 ACKs for top commit: jp1ac4: ACK c002ab9. Tree-SHA512: 83de99d54c427de86dad779549280b3316b0e72a9e3a5cb4af22d44eefa9832408b974f2a2aca0847b13ad5899e324ad43f32e99eb4efb69716c827f3ab47aaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #816, this introduces a new
spendmodule with a helper to create a transaction spending coins from the wallet. It can be leveraged to create regular or recovery transactions, and also replacement for them. All the data structures used by the exposed spend creation function are contained with this module, in order to make it usable without alianad-specific database and Bitcoin interface.This PR is structured in an incremental fashion. First we pull out the
create_spend_internalmethod introduced in #816 into a standalonespendmodule, then we incrementally remove the cruft and the ties from the spend module to the other components.