Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Asset Groups Texts #2009

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Update Asset Groups Texts #2009

merged 5 commits into from
Jul 6, 2023

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Jul 5, 2023 •
edited
Loading

Changes proposed in this Pull Request:

This PR updates some texts based on the Figma updates

Figma - fqR0EHi63lWahRcVTKCcba-fi-5568%3A228053
Project - P2 - pcTzPl-1ue-p2

It updates the next parts of PMAX Assets Groups

  • The Navigation title in Edit Campaign and Create Campaign
  • The Asset Group helper section on the side
  • The Asset Groups Tour content
  • The Asset GRoups FAQ content.

Screenshots:

Before

Screenshot 2023-07-05 at 15 51 42 Screenshot 2023-07-05 at 16 26 25 Screenshot 2023-07-05 at 16 30 57 Screenshot 2023-07-05 at 16 44 20 Screenshot 2023-07-05 at 16 44 11

After

Screenshot 2023-07-05 at 16 04 15 Screenshot 2023-07-05 at 16 49 45 Screenshot 2023-07-05 at 16 26 19 Screenshot 2023-07-05 at 16 27 00

Detailed test instructions:

  1. Go to the Dashboard with your Google Ads Account connected and some Paid campaigns added.
  2. See the tour text updated. (If you don't see the tour maybe you should delete gla_tours in wp_options table)
  3. Edit a paid campaign
  4. See the menu shows now "Optimize your campaigns" in step 2
  5. Advance to step 2
  6. See the title and the heading title matching Figma
  7. See the Side text matching Figma
  8. See the second question of the FAQ matching figma

Additional details:

P2 - pcTzPl-1ue-p2
Figma - fqR0EHi63lWahRcVTKCcba-fi-5568%3A228053

Changelog entry

Tweak - Changes for title, descriptions and FAQ in PMAX Optimized Campaigns

@puntope puntope self-assigned this Jul 5, 2023
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Jul 5, 2023
@puntope puntope requested a review from a team July 5, 2023 12:53
@puntope puntope marked this pull request as ready for review July 5, 2023 12:55
eason9487
eason9487 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! LGTM.

Left two non-blocking comments that could be considered for adjustments.

js/src/components/paid-ads/asset-group/asset-group-section.js Outdated
Comment on lines 52 to 53
context="asset-groups"
linkId="asset-groups-learn-more"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the meaning of "asset group" on this page is a single data collection of grouped assets, it would be a bit properer to use a singular noun.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 3546fdf

js/src/components/paid-ads/asset-group/asset-group-section.js Outdated
<AppDocumentationLink
context="asset-groups"
linkId="asset-groups-learn-more"
href="https://support.google.com/google-ads/answer/10729160?hl=en&ref_topic=11336002"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the query parameters ?hl=en&ref_topic=11336002 could be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 3546fdf

@puntope puntope merged commit 9b77558 into develop Jul 6, 2023
4 checks passed
@puntope puntope deleted the tweak/update-pmax-content branch July 6, 2023 12:47
@eason9487 eason9487 mentioned this pull request Jul 11, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eason9487 eason9487 eason9487 approved these changes

Assignees

@puntope puntope

Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puntope @eason9487