Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Asset Groups Texts #2009

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Update Asset Groups Texts #2009

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5a98cd
Update text in Campaign PMAX assets tour.
puntope Jul 5, 2023
e95218c
Change text from "Boost your campaign" to "Optimize your campaign"
puntope Jul 5, 2023
a7d3feb
Change text from Asset Groups
puntope Jul 5, 2023
4e99229
Change FAQ text
puntope Jul 5, 2023
3546fdf
Apply review suggestions
puntope Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions js/src/components/paid-ads/asset-group/asset-group-section.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import VerticalGapLayout from '.~/components/vertical-gap-layout';
import FinalUrlCard from './final-url-card';
import AssetGroupCard from './asset-group-card';
import './asset-group-section.scss';
import AppDocumentationLink from '.~/components/app-documentation-link';

/**
* Renders the form content for managing an asset group of a campaign with Section UI.
Expand All @@ -29,7 +30,7 @@ export default function AssetGroupSection() {
className="gla-asset-group-section"
title={ createInterpolateElement(
__(
'Add dynamic ad assets <optional>(Optional)</optional>',
'Add additional assets <optional>(Optional)</optional>',
'google-listings-and-ads'
),
{
Expand All @@ -39,12 +40,23 @@ export default function AssetGroupSection() {
}
) }
description={
<p className="gla-asset-group-section__primary-description">
{ __(
'Create ads that effectively boost visibility and generate maximum conversions. Google will mix and match assets to create optimized ads in a variety of formats— maximizing your campaign’s performance.',
'google-listings-and-ads'
) }
</p>
<>
<p className="gla-asset-group-section__primary-description">
{ __(
'Upload text and image assets to effectively reach and engage your target shoppers. Google will mix and match your assets, continually testing combinations to create personalized and optimal shopping experiences.',
'google-listings-and-ads'
) }
</p>
<p>
<AppDocumentationLink
context="asset-groups"
linkId="asset-groups-learn-more"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the meaning of "asset group" on this page is a single data collection of grouped assets, it would be a bit properer to use a singular noun.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 3546fdf

href="https://support.google.com/google-ads/answer/10729160?hl=en&ref_topic=11336002"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the query parameters ?hl=en&ref_topic=11336002 could be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 3546fdf

>
{ __( 'Learn more', 'google-listings-and-ads' ) }
</AppDocumentationLink>
</p>
</>
}
>
<VerticalGapLayout size="medium">
Expand Down
7 changes: 5 additions & 2 deletions js/src/components/paid-ads/asset-group/asset-group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,12 @@ export default function AssetGroup( { campaign } ) {
return (
<StepContent>
<StepContentHeader
title={ __( 'Boost your campaign', 'google-listings-and-ads' ) }
title={ __(
'Optimize your campaign',
'google-listings-and-ads'
) }
description={ __(
'Take your campaign to the next level with dynamic ad assets',
'Drive greater performance by adding text and image assets to create personalized and engaging ads',
'google-listings-and-ads'
) }
/>
Expand Down
4 changes: 2 additions & 2 deletions js/src/components/paid-ads/asset-group/faqs-section.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ const faqItems = [
<>
<div>
{ __(
`Dynamic ad assets can elevate your campaign by offering a variety of ad combinations that capture your audience's attention and generate maximum engagement. By leveraging Google's asset-mixing technology, your ads can be optimized to deliver the right message, to the right people, at the right time.`,
"Text and image assets can elevate your campaign by offering a variety of ad combinations that capture your audience's attention and generate maximum engagement. By leveraging Google's asset-mixing technology, your ads can be optimized to deliver the right message, to the right people, at the right time.",
'google-listings-and-ads'
) }
</div>
<div>
{ __(
'Compared to product ads—which showcase individual products and are designed to drive direct sales and revenue— ads with dynamic assets are typically used to highlight your business, generate interest, and attract new customers. While both types of ads can drive conversions, using them together can generate even greater results.',
'Compared to product ads—which showcase individual products and are designed to drive direct sales and revenue— ads with creative assets are typically used to highlight your business, generate interest, and attract new customers. While both types of ads can drive conversions, using them together can generate even greater results.',
'google-listings-and-ads'
) }
</div>
Expand Down
4 changes: 2 additions & 2 deletions js/src/dashboard/all-programs-table-card/campaign-assets-tour.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default function CampaignAssetsTour( { referenceElementCssSelector } ) {
<div className="gla-campaign-assets-tour__heading">
<GridiconTrending />
{ __(
'Boost your campaign',
'Optimize your campaign',
'google-listings-and-ads'
) }
<Pill>
Expand All @@ -54,7 +54,7 @@ export default function CampaignAssetsTour( { referenceElementCssSelector } ) {
desktop: (
<>
{ __(
'Create ads that boost visibility and maximize campaign performance using dynamic ad assets.',
'Add images, headlines, and descriptions to drive better engagement and more sales.',
'google-listings-and-ads'
) }
<br />
Expand Down
2 changes: 1 addition & 1 deletion js/src/pages/create-paid-ads-campaign/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ const CreatePaidAdsCampaign = () => {
{
key: STEP.ASSET_GROUP,
label: __(
'Boost your campaign',
'Optimize your campaign',
'google-listings-and-ads'
),
content: <AssetGroup />,
Expand Down
2 changes: 1 addition & 1 deletion js/src/pages/edit-paid-ads-campaign/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ const EditPaidAdsCampaign = () => {
{
key: STEP.ASSET_GROUP,
label: __(
'Boost your campaign',
'Optimize your campaign',
'google-listings-and-ads'
),
content: <AssetGroup campaign={ campaign } />,
Expand Down