Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Budget Setup Card. #2552

Open
wants to merge 29 commits into
base: update/2535-consolidate-ad-creation-ccf-merged
Choose a base branch
from
+348 −52

Merge pull request #2637 from woocommerce/update/2502-budget-setup-ca…

f6f7ac3
Select commit
Loading
Failed to load commit list.
Open

Update Budget Setup Card. #2552

Merge pull request #2637 from woocommerce/update/2502-budget-setup-ca…
f6f7ac3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 0s

60.7% (-0.3%) compared to 34c53d7

View this Pull Request on Codecov

60.7% (-0.3%) compared to 34c53d7

Details

Codecov Report

Attention: Patch coverage is 9.61538% with 47 lines in your changes missing coverage. Please review.

Project coverage is 60.7%. Comparing base (34c53d7) to head (f6f7ac3).

Files with missing lines Patch % Lines
js/src/data/resolvers.js 0.0% 13 Missing and 3 partials ⚠️
...paid-ads-setup-sections/paid-ads-setup-sections.js 0.0% 9 Missing and 2 partials ⚠️
js/src/utils/getHighestBudget.js 0.0% 5 Missing and 2 partials ⚠️
js/src/hooks/useFetchBudgetRecommendation.js 16.7% 5 Missing ⚠️
...ign/paid-ads-setup-sections/paid-ads-setup-form.js 0.0% 2 Missing and 1 partial ⚠️
js/src/data/selectors.js 33.3% 1 Missing and 1 partial ⚠️
js/src/data/utils.js 0.0% 2 Missing ⚠️
...-ads/budget-section/budget-recommendation/index.js 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                                @@
##           update/2535-consolidate-ad-creation-ccf-merged   #2552     +/-   ##
================================================================================
- Coverage                                            61.0%   60.7%   -0.3%     
================================================================================
  Files                                                 330     331      +1     
  Lines                                                5183    5210     +27     
  Branches                                             1254    1264     +10     
================================================================================
+ Hits                                                 3162    3165      +3     
- Misses                                               1832    1851     +19     
- Partials                                              189     194      +5
Files with missing lines Coverage Δ
...-campaign/paid-ads-setup-sections/clientSession.js 33.3% <ø> (ø)
js/src/components/paid-ads/budget-section/index.js 13.3% <ø> (+2.8%) ⬆️
js/src/data/action-types.js 100.0% <ø> (ø)
js/src/data/reducer.js 83.8% <100.0%> (+0.3%) ⬆️
...-ads/budget-section/budget-recommendation/index.js 5.0% <0.0%> (+1.0%) ⬆️
js/src/data/selectors.js 47.1% <33.3%> (-0.4%) ⬇️
js/src/data/utils.js 94.1% <0.0%> (-3.8%) ⬇️
...ign/paid-ads-setup-sections/paid-ads-setup-form.js 3.0% <0.0%> (ø)
js/src/hooks/useFetchBudgetRecommendation.js 16.7% <16.7%> (ø)
js/src/utils/getHighestBudget.js 0.0% <0.0%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

View more details on Codecov