refactor: 앱 설치 버튼 구현 및 버튼 누르면 나오는 설치 방법 설명 모달 구현한다 #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
frontend/public/manifest.json
Outdated
There was a problem hiding this comment.
pwa 설정을 위해 있어야 하는 파일입니다. lighthouse pwa를 통해 어떤 부분이 빠졌는지 확인할 수 있어요.
링크 공유를 할 때 어떤 이름과 설명, 이미지가 나올 지, 웹앱 설치를 했을 때 어떻게 화면에 보이게 할 건지 등 많은 걸 설정할 수 있습니다!
| const render = (status: Status) => { | ||
| switch (status) { | ||
| case Status.LOADING: | ||
| return <Loading />; | ||
| case Status.FAILURE: | ||
| return <>에러 발생</>; | ||
| return <NotFound />; |
| width="70px" | ||
| height="70px" | ||
| justifyContent="center" | ||
| alignItems="center" | ||
| border={true} | ||
| border |
There was a problem hiding this comment.
이 부분에서 발생하는 콘솔 에러는 디자인 시스템 레포지토리로 분리된 이후에 버그 수정하겠습니다.
There was a problem hiding this comment.
ㅇ ㅖ, 아니면 emotion으로 개선하면서 자연스럽게 없애도 될 것 같네여
gabrielyoon7
approved these changes
Oct 24, 2023
kyw0716
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🕰️ Actual Time of Completion
🙋🏻 More
close #899
🚀 Storybook