-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 앱 설치 버튼 구현 및 버튼 누르면 나오는 설치 방법 설명 모달 구현한다 #900
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,12 +10,12 @@ const StyledClusterMarker = ({ count }: StyledClusterMarkerProps) => { | |
<FlexBox | ||
p={4} | ||
borderRadius="50%" | ||
bgColor="#D9E5FF" | ||
bgColor="#d9e5ffcb" | ||
width="70px" | ||
height="70px" | ||
justifyContent="center" | ||
alignItems="center" | ||
border={true} | ||
border | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 부분에서 발생하는 콘솔 에러는 디자인 시스템 레포지토리로 분리된 이후에 버그 수정하겠습니다. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ㅇ ㅖ, 아니면 emotion으로 개선하면서 자연스럽게 없애도 될 것 같네여 |
||
borderColor="#3366FF" | ||
borderWidth="1px" | ||
> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
import { XMarkIcon } from '@heroicons/react/24/outline'; | ||
import { FlexBox } from 'car-ffeine-design-system'; | ||
|
||
import { BsArrowDownSquare, BsPlusSquare } from 'react-icons/bs'; | ||
import { FiMoreVertical } from 'react-icons/fi'; | ||
import { IoShareOutline } from 'react-icons/io5'; | ||
import { MdInstallDesktop, MdInstallMobile } from 'react-icons/md'; | ||
|
||
import { modalActions } from '@stores/layout/modalStore'; | ||
|
||
import useMediaQueries from '@hooks/useMediaQueries'; | ||
|
||
import Button from '@common/Button'; | ||
import Text from '@common/Text'; | ||
|
||
const HowToAppInstallModal = () => { | ||
const screen = useMediaQueries(); | ||
|
||
return ( | ||
<FlexBox | ||
maxWidth={40} | ||
width="calc(100vw - 4.8rem)" | ||
rowGap={2} | ||
pt={4} | ||
px={6} | ||
pb={10} | ||
direction="column" | ||
> | ||
<Button mt={-1} mr={-3} mb={-2} ml="auto" onClick={modalActions.closeModal}> | ||
<XMarkIcon width={28} /> | ||
</Button> | ||
{screen.get('isMobile') ? ( | ||
<></> | ||
) : ( | ||
<FlexBox direction="column" rowGap={2} mb={3}> | ||
<Text tag="h2" variant="h6"> | ||
크롬 브라우저인가요? | ||
</Text> | ||
<FlexBox tag="p" alignItems="center"> | ||
주소창 오른쪽에 위치한 | ||
<MdInstallDesktop size={20} display="inline-block" /> 아이콘을 누르세요. | ||
</FlexBox> | ||
<Text tag="h3">아쉽게도 사파리는 지원하지 않습니다</Text> | ||
</FlexBox> | ||
)} | ||
<div> | ||
<Text tag="h2" variant="h6" mb={2}> | ||
IOS 모바일인가요? | ||
</Text> | ||
<FlexBox tag="p" alignItems="center" mb={2}> | ||
주소창 근처에 있는 <IoShareOutline size={20} /> | ||
아이콘을 누르세요. | ||
</FlexBox> | ||
<FlexBox tag="p" alignItems="center"> | ||
그리고 홈 화면에 추가 <BsPlusSquare size={20} />를 눌러주세요. | ||
</FlexBox> | ||
</div> | ||
<div> | ||
<Text tag="h2" variant="h6" mt={3} mb={2}> | ||
안드로이드인가요? | ||
</Text> | ||
<FlexBox tag="p" alignItems="center" mb={2}> | ||
주소창 오른쪽에 위치한 <BsArrowDownSquare size={20} /> | ||
아이콘을 누르거나 | ||
</FlexBox> | ||
<FlexBox tag="p" alignItems="center"> | ||
<FiMoreVertical /> 아이콘을 누른 뒤, 앱 설치 버튼 | ||
<MdInstallMobile size={20} />을 누르세요. | ||
</FlexBox> | ||
</div> | ||
</FlexBox> | ||
); | ||
}; | ||
|
||
export default HowToAppInstallModal; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
드디어 생기는군요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ