다른 사람의 알림까지 보이는 문제 해결 #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woo-chang
approved these changes
Oct 18, 2023
| PostAlarmDetailResponse postAlarmDetailResponse = new PostAlarmDetailResponse(1L, "title", "저문"); | ||
| PostAlarmResponse postAlarmResponse = new PostAlarmResponse(1L, postAlarmDetailResponse, | ||
| LocalDateTime.now(), false); | ||
|
|
||
| given(alarmQueryService.getPostAlarm(page)).willReturn(List.of(postAlarmResponse)); | ||
| given(alarmQueryService.getPostAlarm(page, member)).willReturn(List.of(postAlarmResponse)); |
There was a problem hiding this comment.
Q
any를 사용하지 않은 이유가 있으신가요?!
There was a problem hiding this comment.
급하게 변경하느라 생각을 못했네요 변경해보겠습니다!
| @@ -46,4 +54,25 @@ private String makeNicknameBy(final Alarm alarm) { | |||
| return member.getNickname(); | |||
| } | |||
|
|
|||
| @Transactional(readOnly = true) | |||
There was a problem hiding this comment.
P3
QueryService라 @Transactional을 다 제거해도 괜찮을 것 같아요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
close: #771
📝 작업 요약
다른 사람의 알림까지 보이는 문제 해결
자신이 작성한 게시글에 자신이 댓글을 다는 경우 알림이 안오도록 수정
루쿠의 신고 알림과 클래스 합치는 작업
⏰ 소요 시간
30분
🔎 작업 상세 설명
없음.
🌟 논의 사항
없음.