-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
다른 사람의 알림까지 보이는 문제 해결 #773
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
634a928
refactor: (#743) 요청한 회원의 알림만 보이도록 변경
jeomxon ca06307
refactor: (#743) conflict 해결
jeomxon 239fba5
refactor: (#743) 자신의 게시글에 댓글을 작성하는 경우 알림 이벤트를 발행하지 않도록 수정
jeomxon f1335bb
test: (#743) 비동기 테스트 지연 시간 설정
jeomxon bba0c8e
chore: (#743) truncate.sql에 새로 추가된 테이블 추가
jeomxon 5a0b967
refactor: (#743) docs 명세 코드 수정
jeomxon 112ef29
test: (#743) 비동기 검증 sleep 시간 1초 추가
jeomxon 85ee935
refactor: (#743) 불필요한 어노테이션 제거 및 any()를 사용하도록 변경
jeomxon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
44 changes: 0 additions & 44 deletions
44
backend/src/main/java/com/votogether/domain/alarm/controller/AlarmCommandController.java
This file was deleted.
Oops, something went wrong.
23 changes: 0 additions & 23 deletions
23
backend/src/main/java/com/votogether/domain/alarm/controller/AlarmCommandControllerDocs.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,9 @@ | ||
package com.votogether.domain.alarm.controller; | ||
|
||
import com.votogether.domain.alarm.dto.ReportActionAlarmResponse; | ||
import com.votogether.domain.alarm.dto.ReportActionResponse; | ||
import com.votogether.domain.member.entity.Member; | ||
import io.swagger.v3.oas.annotations.Operation; | ||
import io.swagger.v3.oas.annotations.Parameter; | ||
import io.swagger.v3.oas.annotations.responses.ApiResponse; | ||
import io.swagger.v3.oas.annotations.tags.Tag; | ||
import jakarta.validation.constraints.PositiveOrZero; | ||
import java.util.List; | ||
import org.springframework.http.ResponseEntity; | ||
|
||
@Tag(name = "알림", description = "알림 API") | ||
public interface AlarmCommandControllerDocs { | ||
|
||
@Operation(summary = "신고조치알림 조회", description = "신고조치알림목록을 조회한다.") | ||
@ApiResponse(responseCode = "201", description = "조회 성공") | ||
ResponseEntity<List<ReportActionAlarmResponse>> getReportActionAlarms( | ||
@Parameter(description = "현재 페이지 위치", example = "0") | ||
@PositiveOrZero(message = "페이지는 0이상 정수만 가능합니다.") final int page, | ||
final Member member | ||
); | ||
|
||
@Operation(summary = "신고조치알림 상세 조회", description = "신고조치알림를 상세 조회한다.") | ||
@ApiResponse(responseCode = "201", description = "조회 성공") | ||
public ResponseEntity<ReportActionResponse> getReportActionAlarm( | ||
@Parameter(description = "신고조치알림 ID", example = "1") final Long reportActionAlarmId, | ||
final Member member | ||
); | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 0 additions & 45 deletions
45
backend/src/main/java/com/votogether/domain/alarm/service/AlarmService.java
This file was deleted.
Oops, something went wrong.
90 changes: 0 additions & 90 deletions
90
backend/src/test/java/com/votogether/domain/alarm/controller/AlarmCommandControllerTest.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3
QueryService
라@Transactional
을 다 제거해도 괜찮을 것 같아요 :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
삭제하겠습니다!