Merge the "Move fastlane into project root" changes into develop #15884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olivier Halligon <[email protected]>
# Conflicts: # fastlane/metadata/ar-SA/release_notes.txt # fastlane/metadata/de-DE/release_notes.txt # fastlane/metadata/default/release_notes.txt # fastlane/metadata/en-GB/release_notes.txt # fastlane/metadata/en-US/release_notes.txt # fastlane/metadata/es-ES/release_notes.txt # fastlane/metadata/es-MX/release_notes.txt # fastlane/metadata/fr-FR/release_notes.txt # fastlane/metadata/id/release_notes.txt # fastlane/metadata/it/release_notes.txt # fastlane/metadata/ja/release_notes.txt # fastlane/metadata/ko/release_notes.txt # fastlane/metadata/nl-NL/release_notes.txt # fastlane/metadata/ru/release_notes.txt # fastlane/metadata/sv/release_notes.txt # fastlane/metadata/tr/release_notes.txt # fastlane/metadata/zh-Hans/release_notes.txt # fastlane/metadata/zh-Hant/release_notes.txt
Co-authored-by: Olivier Halligon <[email protected]>
Co-authored-by: Olivier Halligon <[email protected]>
Co-authored-by: Olivier Halligon <[email protected]>
Co-authored-by: Olivier Halligon <[email protected]>
Move Fastlane to Project Root
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
AliSoftware
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
I have to admit that I didn't review this one as in-depth as the original one, but the diff and git graph makes sense to me, so we should be good.
(I noticed that the PR re-adds the fastlane/metadata/*/release_notes.txt files needlessly, but I don't think that's a big deal so 👍 )
jkmassel
deleted the
merge/move-fastlane-into-project-root-into-develop
branch
dcalhoun
added a commit
that referenced
this pull request
Feb 15, 2021
These styling violations likely occurred during the relocation of Fastlane files to the top-level directory. #15884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this is a huge change, I'd like to land this in
developindependent of other changes (instead of trying to sort through a beta fix with all this stuff cluttering up the PR).It was already approved in #15706 and these changes should be identical – immediately following the PR merge, I cut this branch from
release/16.7.