Integrate Gravatar SDK #22921

pinarol · 2024-03-29T11:15:31Z

Fixes #22543

WordPressUI PR: wordpress-mobile/WordPressUI-iOS#156

Adds a new dependency: Gravatar
Replaces WordPressUI.Gravatar usage with Gravatar.AvatarURL
Starts using Gravatar.AvatarService.upload(...) to upload an avatar
WordpressUICacheAdapter now also conforms to Gravatar.ImageCaching.
Adds extension UIImageView to add new alternatives of what’s deprecated in WordPressUI. (All related with downloading an Avatar.)
Updates GravatarServiceTests

No new functionality is added. This is just to replace code & refactor.

I'll add some screenshots with avatars to make dangermattic happy.

To test:

Regression Notes

Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

# Conflicts: # Podfile.lock

* Use GravatarURL instead of Gravatar * Use GravatarURL in ListTableViewCell --------- Co-authored-by: Pinar Olguc <[email protected]>

# Conflicts: # Podfile.lock

Co-authored-by: Pinar Olguc <[email protected]>

…2641) Co-authored-by: Pinar Olguc <[email protected]>

…-fetch-profile-from-gravatar-sdk

…col naming (#22681)

Co-authored-by: Pinar Olguc <[email protected]>

* Update podfile Gravatar testspecs * bundle exec pod install --------- Co-authored-by: Pinar Olguc <[email protected]>

We won't use the SDK until we have an open api-based endpoint for it

…ery/use-new-identifier-types

wpmobilebot · 2024-03-29T11:46:30Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22921-50e5dbb
	Version	24.6
	Bundle ID	org.wordpress.alpha
	Commit	`50e5dbb`
	App Center Build	WPiOS - One-Offs #9347

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot · 2024-03-29T11:46:35Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22921-50e5dbb
	Version	24.6
	Bundle ID	com.jetpack.alpha
	Commit	`50e5dbb`
	App Center Build	jetpack-installable-builds #8391

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

pinarol · 2024-03-29T12:40:24Z

cc: @alpavanoglu @kean Could you take a look as well? Not sure who else to tag so please feel free to tag others who might be interested. We don't expect you to run the tests(although you are highly welcome if you want to). Just let us know if you have any concerns & comments. Thank you!

pinarol · 2024-03-29T12:43:34Z

Also, here's the alternative change set that imports Gravatar from WordPressUI:

https://github.com/wordpress-mobile/WordPress-iOS/compare/task/gravatar-integration?expand=1
https://github.com/wordpress-mobile/WordPressUI-iOS/compare/task/gravatar-integration?expand=1

The reason why we didn't pursue that is because WordPressUI has deployment target set to iOS 11 and this is too low for our SDK. Gravatar SDK’s is iOS 15. For us, it’s better not to be bound by WPUI’s target version as we go down the road. Because we’ll add more features in the SDK and we would like to make the most of modern Apple APIs. So it would be easier for us to move fwd with this PR.

But let us know if you think this one is better.

# Conflicts: # Podfile.lock

etoledom

All looks good to me!

Smoke-tested using the test cases from #22543

✅

# Conflicts: # Podfile.lock

pinarol · 2024-04-02T06:51:32Z

But let us know if you think this one is better.

We talked in Slack. We decided to move fwd with this solution.

pinarol and others added 30 commits January 23, 2024 12:57

Add Gravatar and point it to local

f1281ef

Point WordPressUI to local folder

875a946

Merge branch 'trunk' into task/gravatar-integration

5d8f368

# Conflicts: # Podfile.lock

Use GravatarURL instead of Gravatar (#22600)

a2cc105

* Use GravatarURL instead of Gravatar * Use GravatarURL in ListTableViewCell --------- Co-authored-by: Pinar Olguc <[email protected]>

Merge branch 'trunk' into task/gravatar-integration

a061bb7

# Conflicts: # Podfile.lock

Use GravatarURL in more places (#22624)

74fdffc

Co-authored-by: Pinar Olguc <[email protected]>

Using Gravatar.fetchProfile from Gravatar SDK

d72bcfd

Replace the download avatar via email with the SDK implementation (#2…

4035beb

…2641) Co-authored-by: Pinar Olguc <[email protected]>

Merge branch 'task/gravatar-integration' into gravatar/etoledom/using…

109e40d

…-fetch-profile-from-gravatar-sdk

[gravatar] Using Gravatar.fetchProfile from Gravatar SDK (#22635)

1b4744c

Replacing Gravatar upload image with Gravatar SDK ImageService

7d6854a

Update gravatarImageService related unit tests

94f9cca

[Gravatar] Image upload using Gravatar SDK (#22657)

7da3c42

Implementing Gravatar changes regarding ImageServing protocol naming

da2f87d

[Gravatar] Implementing Gravatar changes regarding ImageServing proto…

96cad59

…col naming (#22681)

Fix build error after errors PR merge in Gravatar SDK

5ccc6b4

Gravatar: Fix build error after errors PR merge in Gravatar SDK (#22718)

83825be

Update GravatarProfile to UserProfile

28d06d7

[Gravatar] Update UserProfile name (#22856)

4e15f39

Update GravatarService to use the new AvatarService (#22878)

930dc08

Co-authored-by: Pinar Olguc <[email protected]>

Update podfile: Gravatar testspecs (#22889)

5396304

* Update podfile Gravatar testspecs * bundle exec pod install --------- Co-authored-by: Pinar Olguc <[email protected]>

Fetch gravatar profile using async fetch method

989cf60

Remove noninsolated from fetchGravatarProfile

f325403

[Gravatar] Fetch Gravatar profile using async fetch method (#22894)

f5bc025

Roll back usage of fetch Gravatar profile

76f07c4

We won't use the SDK until we have an open api-based endpoint for it

Use new Identifier types

7d32180

Implement URL name changes

0b16099

[Gravatar] Rollback usage of fetch Gravatar profile (#22904)

8820499

Implement URL name changes (#22911)

9eb7ede

Merge branch 'task/gravatar-integration' into gravatar/andrewdmontgom…

edb514f

…ery/use-new-identifier-types

pinarol added 2 commits March 29, 2024 14:34

Update tests

7a6df64

Run pod install

ad5833f

pinarol added 3 commits March 29, 2024 14:56

Fallback to internal cache

49d78a0

Use explicit type

abed54a

Revert

b8f9b6a

pinarol self-assigned this Mar 29, 2024

pinarol requested a review from etoledom March 29, 2024 12:17

pinarol mentioned this pull request Mar 29, 2024

Gravatar SDK integration wordpress-mobile/WordPressUI-iOS#156

Merged

1 task

pinarol added this to the 24.6 milestone Mar 29, 2024

pinarol marked this pull request as ready for review March 29, 2024 12:40

pinarol added the Feature Gravatar SDK integration label Mar 29, 2024

pinarol modified the milestones: 24.6, 24.7 Mar 29, 2024

pinarol added 3 commits March 29, 2024 17:39

Use AvatarURL

0b56439

Merge branch 'trunk' into wppinar/move-gravatar

4662f8a

# Conflicts: # Podfile.lock

pod install

e101f36

etoledom approved these changes Apr 1, 2024

View reviewed changes

pinarol added 4 commits April 2, 2024 08:57

Update WordPressUI as 1.16

6762d7d

Merge branch 'trunk' into wppinar/move-gravatar

ae93312

# Conflicts: # Podfile.lock

Bump Gravatar-SDK-iOS to 1.0.0

e421b1f

Update Gravatar as 1.0.0

50e5dbb

pinarol enabled auto-merge (squash) April 2, 2024 06:50

pinarol merged commit c2d4a35 into trunk Apr 2, 2024
24 of 27 checks passed

pinarol deleted the wppinar/move-gravatar branch April 2, 2024 07:45

pinarol mentioned this pull request Jul 18, 2024

Remove Gravatar related deprecated types and replace with Gravatar SDK #23429

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate Gravatar SDK #22921

Integrate Gravatar SDK #22921

pinarol commented Mar 29, 2024 •

edited

Loading

wpmobilebot commented Mar 29, 2024 •

edited

Loading

wpmobilebot commented Mar 29, 2024 •

edited

Loading

pinarol commented Mar 29, 2024

pinarol commented Mar 29, 2024 •

edited

Loading

etoledom left a comment

pinarol commented Apr 2, 2024

Integrate Gravatar SDK #22921

Integrate Gravatar SDK #22921

Conversation

pinarol commented Mar 29, 2024 • edited Loading

Regression Notes

wpmobilebot commented Mar 29, 2024 • edited Loading

wpmobilebot commented Mar 29, 2024 • edited Loading

pinarol commented Mar 29, 2024

pinarol commented Mar 29, 2024 • edited Loading

etoledom left a comment

Choose a reason for hiding this comment

pinarol commented Apr 2, 2024

pinarol commented Mar 29, 2024 •

edited

Loading

wpmobilebot commented Mar 29, 2024 •

edited

Loading

wpmobilebot commented Mar 29, 2024 •

edited

Loading

pinarol commented Mar 29, 2024 •

edited

Loading