Move xcdatamodeld into WordPressData
#24166
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See how https://buildkite.com/automattic/wordpress-ios/builds/25994 failed: ``` error: Build input file cannot be found: '/opt/ci/builds/builder/automattic/wordpress-ios/DerivedData/Build/Intermediates.noindex/ArchiveIntermediates/WordPress Alpha/BuildProductsPath/Release-Alpha-iphoneos/WordPressDataObjC.o'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it? (in target 'WordPress' from project 'WordPress') ```
Not sure how it was working before — and in CI too, see https://buildkite.com/automattic/wordpress-ios/builds/25995 My only guess is that the file became available in the DerivedData somehow because the Swift package importing it was built before the app targets? Odd...
It was needed just because there was no file in the package yet, but we've addressed it whenw e moved `CoreDataService` in there.
So we can use it next in WordPressData.
Generated by 🚫 Danger |
mokagio
commented
Mar 7, 2025
| <entity name="BloggingPrompt" representedClassName=".BloggingPrompt" syncable="YES"> | ||
| <entity name="BloggingPrompt" representedClassName="WordPressData.BloggingPrompt" syncable="YES"> |
mokagio
commented
Mar 7, 2025
Comment on lines
+3
to
+27
| public let modelURL: URL = { | ||
| guard let url = Bundle.module.url(forResource: "WordPress", withExtension: "momd") else { | ||
| fatalError("Cannot find model file.") | ||
| } | ||
| return url | ||
| }() | ||
|
|
||
| public func urlForModel(name: String, in directory: String?) -> URL? { | ||
| let bundle = Bundle(for: TemporaryDummyClassToPickUpModule.self) | ||
| var url = bundle.url(forResource: name, withExtension: "mom", subdirectory: directory) | ||
|
|
||
| if url != nil { | ||
| return url | ||
| } | ||
|
|
||
| let momdPaths = bundle.paths(forResourcesOfType: "momd", inDirectory: directory) | ||
| momdPaths.forEach { (path) in | ||
| if url != nil { | ||
| return | ||
| } | ||
| url = bundle.url(forResource: name, withExtension: "mom", subdirectory: URL(fileURLWithPath: path).lastPathComponent) | ||
| } | ||
|
|
||
| return url | ||
| } |
There was a problem hiding this comment.
These free functions should go into an object at some point.
It was just simpler to chuck them in here at this stage while I figure things out.
Also, I'd like to think there will be no need to have them public once all the types involved in setting up the Core Data stack have been moved.
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24166-b94d69d | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b94d69d | |
| App Center Build | jetpack-installable-builds #10637 |
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24166-b94d69d | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b94d69d | |
| App Center Build | WPiOS - One-Offs #11606 |
|
Have you tried overriding an Objective-C class name for the managed objects written in Swift? |
mokagio
force-pushed
the
mokagio/share-classNameWithoutNamespaces
branch
from
81890b9 to
57a9e60
Compare
Base automatically changed from
mokagio/share-classNameWithoutNamespaces
to
trunk
March 7, 2025 21:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24165
Note
Work in Progress. So far:
xcdatamodeldfolder into the module and updated the code that referenced its URL to read it from the moduleBloggingPrompt(apparently the first model to load at runtime). The error was withFatal error: NSArray element failed to match the Swift Array Element type . Expected BloggingPrompt got NSManagedObject.BloggingPromptto WordPressDataFatal error: NSArray element failed to match the Swift Array Element type . Expected BloggingPrompt got NSManagedObjectI don't like this solution because it would require editing the schema for each model. Besides, the compiler (or whichever piece is involved in going from the schema to the binary) should be able to inject the correct module name without hardcoding.
Leaving this up as a draft so that others can look at it.
The next thing I'll try will be to move more of the components involved in making the Core Data fetch request, the
NSManagedObjectContextin particular, and see if it gets the namespace resolution to work without hardcoding.Fixes #
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: