Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal gracefully with symlinks #59

Closed
wants to merge 7 commits into from
Closed

Deal gracefully with symlinks #59

wants to merge 7 commits into from

Conversation

BrianHenryIE
Copy link
Member

@BrianHenryIE BrianHenryIE commented Jun 3, 2022 •
edited by schlessera
Loading

Needs tests.

Has a nice test that fails on main and passes with this PR.

Fixes #57

@BrianHenryIE BrianHenryIE mentioned this pull request Jun 3, 2022
Closed
2 tasks
@BrianHenryIE BrianHenryIE marked this pull request as ready for review June 16, 2022 00:52
@BrianHenryIE BrianHenryIE requested a review from a team as a code owner June 16, 2022 00:52
schlessera
schlessera requested changes Jun 30, 2022
View reviewed changes
Copy link
Member

@schlessera schlessera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good so far apart from a minor whitespace nitpick.

However, I think the testing needs to account for more scenarios to cover the code.

features/dist-archive.feature
Comment on lines +232 to +233
wp-content
wordpress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests should trigger the extra regex rules as well to ensure they work as expected:

  • using an asterisk
  • using a slash
  • using a dot

@schlessera schlessera changed the title Fix #57 Check is there a symlink in the plugin; copy non-ignored files to temp Deal gracefully with symlinks Jun 30, 2022
BrianHenryIE and others added 2 commits June 30, 2022 22:43
@schlessera
Copy link
Member

@BrianHenryIE Now that I'm looking at the code again with fresh eyes... is there a reason why you're using closures in the first place? These two closures should rather be private methods of the class...

@BrianHenryIE
Copy link
Member Author

BrianHenryIE commented Jul 1, 2022 •
edited
Loading

Not particularly. Probably because there's no PHPUnit tests needing them be callable functions.

Why private instead of protected? static still?

This was referenced Jul 7, 2022
Closed
Merged
@BrianHenryIE BrianHenryIE marked this pull request as draft July 8, 2022 00:42
@danielbachhuber
Copy link
Member

Ship #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symlink in ignored directory causing out of memory error
3 participants
@BrianHenryIE @schlessera @danielbachhuber