Allow for leading slashes in .distignore, and deal gracefully with symlinks #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working for zip Not quite working for tar The tar command is correct and works when I run it on the command line, but the tests are failing to exclude the file properly.
Fails on main wp-cli@eba7d1c Passes with PR wp-cli#59
Working for zip Not quite working for tar The tar command is correct and works when I run it on the command line, but the tests are failing to exclude the file properly.
Co-authored-by: Alain Schlesser <[email protected]>
Co-authored-by: Alain Schlesser <[email protected]>
1. It seems `sys_get_temp_dir()` was being shared across multiple tests, so files already existed when subsequent tests were run. 2. Looks like the "no distignore file is present" test was failing after wp-cli#56 was merged.
…m/BrianHenryIE/dist-archive-command into anchor-distignore-entries-to-root
|
Dammit, tests working locally on MacOS and not on GitHub Actions! Syntax differences between |
wojsmol
reviewed
Aug 3, 2022
Failing tests in GitHub Actions CI were trying to run it. https://wordpress.slack.com/archives/C02RP4T41/p1659554836197889
`tar`'s `--anchored` is not available on MacOS. On MacOS `tar`, to anchor, exclusions are written with `^` regex character.
|
I needed to use
|
danielbachhuber
changed the title
|
Thanks @BrianHenryIE, appreciate your work on this. I'll review this at depth when I have some time in the near future. |
danielbachhuber
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
This looks great me, @BrianHenryIE.
Thanks again for your effort on it, and your thorough tests. The tests pass for me locally on Mac.
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tests and fixes for PRs #58 and #59.
The tests for 58 were relevant to those needed for 59.
The code in 59 fixed some of the issue in 58.
Closes #57 and #47.
PHPUnit tests are added to this repo for the first time and should be helpful for work that might be done on #15 and #44.