Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attributes to system schema #6336

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

amanda-ariyaratne
Copy link
Contributor

Proposed changes in this pull request

$subject

Related Issues

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.85%. Comparing base (6224337) to head (e1b669c).
Report is 24 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6336      +/-   ##
============================================
+ Coverage     45.45%   45.85%   +0.40%     
- Complexity    14440    14547     +107     
============================================
  Files          1701     1696       -5     
  Lines        103368   105122    +1754     
  Branches      18063    18886     +823     
============================================
+ Hits          46986    48204    +1218     
- Misses        49585    50015     +430     
- Partials       6797     6903     +106     
Flag Coverage Δ
unit 29.83% <ø> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amanda-ariyaratne
Copy link
Contributor Author

The integration tests were run locally with the changes in following PRs.

  1. Add SCIM System Schema charon#418
  2. Move attributes to system schema #6336
  3. Add SCIM System Schema wso2-extensions/identity-inbound-provisioning-scim2#594
  4. Fix integration tests for system and custom schema product-is#22361

We can merge PRs 1, 2 & 3 and bump their versions in PR 4 and run the integration tests again. Since they are dependent, running the PR builder alone is expected to fail the integration tests.

Screenshot 2025-01-22 at 21 36 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants