-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCIM System Schema #418
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
============================================
+ Coverage 28.40% 29.98% +1.57%
- Complexity 919 970 +51
============================================
Files 133 134 +1
Lines 13007 13138 +131
Branches 2504 2518 +14
============================================
+ Hits 3695 3939 +244
+ Misses 8839 8703 -136
- Partials 473 496 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f84a42d
to
4a8203d
Compare
...s/charon-core/src/main/java/org/wso2/charon3/core/config/SCIMUserSchemaExtensionBuilder.java
Outdated
Show resolved
Hide resolved
...charon-core/src/main/java/org/wso2/charon3/core/config/SCIMSystemSchemaExtensionBuilder.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/encoder/JSONEncoder.java
Outdated
Show resolved
Hide resolved
...haron-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/SchemaResourceManager.java
Outdated
Show resolved
Hide resolved
...haron-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/SchemaResourceManager.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/schema/SCIMConstants.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/schema/SCIMResourceSchemaManager.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/schema/SCIMResourceSchemaManager.java
Outdated
Show resolved
Hide resolved
PR builder started |
address review comments
77c3905
to
97e9ab2
Compare
PR builder completed |
PR builder started |
PR builder completed |
The integration tests were run locally with the changes in following PRs.
We can merge PRs 1, 2 & 3 and bump their versions in PR 4 and run the integration tests again. ![]() |
...charon-core/src/main/java/org/wso2/charon3/core/config/SCIMSystemSchemaExtensionBuilder.java
Show resolved
Hide resolved
...charon-core/src/main/java/org/wso2/charon3/core/config/SCIMSystemSchemaExtensionBuilder.java
Outdated
Show resolved
Hide resolved
...charon-core/src/main/java/org/wso2/charon3/core/config/SCIMSystemSchemaExtensionBuilder.java
Outdated
Show resolved
Hide resolved
...charon-core/src/main/java/org/wso2/charon3/core/config/SCIMSystemSchemaExtensionBuilder.java
Outdated
Show resolved
Hide resolved
...charon-core/src/main/java/org/wso2/charon3/core/config/SCIMSystemSchemaExtensionBuilder.java
Outdated
Show resolved
Hide resolved
...charon-core/src/main/java/org/wso2/charon3/core/config/SCIMSystemSchemaExtensionBuilder.java
Outdated
Show resolved
Hide resolved
...charon-core/src/main/java/org/wso2/charon3/core/config/SCIMSystemSchemaExtensionBuilder.java
Outdated
Show resolved
Hide resolved
…/SCIMSystemSchemaExtensionBuilder.java Co-authored-by: sadilchamishka <[email protected]>
JSONObject rawAttributeConfig = attributeConfigArray.getJSONObject(index); | ||
ExtensionAttributeSchemaConfig schemaAttributeConfig = | ||
new ExtensionAttributeSchemaConfig(rawAttributeConfig); | ||
if (schemaAttributeConfig.getURI().startsWith(extensionRootAttributeURI)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the schemaAttributeConfig.getURI() be null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. getJSONObject always returns a JSON object. If there are parsing errors, then an exception is thrown.
modules/charon-core/src/main/java/org/wso2/charon3/core/schema/SCIMResourceSchemaManager.java
Show resolved
Hide resolved
8ee1062
Purpose
Add SCIM system schema extension and refactor related components
This pull request introduces a new System User Schema to the SCIM library which will contain the product related SCIM attributes. Additionally, minor cleanups and refactors have been made for consistency and clarity.
Related Issue