YSP-353: Release Bug: Footer link style #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-component-library-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dblanken-yale
force-pushed
the
YSP-353-fix-footer-shadow
branch
from
9aa2451 to
021992a
Compare
codechefmarc
approved these changes
Feb 22, 2024
dblanken-yale
added
pass code review
pass functional review
and removed
needs review
labels
When changing to a background that is not white, the links that are decorated with underlines have an attribute of a white shadow on it. This results in a terrible looking link. The way this passed in the past was that we had a white background with a white shadow, so it looked ok. This now mimics the same attempting to match the footer background. Right now we are just targeting the footer since it was found only here, but it makes me wonder if we need the shadow?
dblanken-yale
force-pushed
the
YSP-353-fix-footer-shadow
branch
from
021992a to
0ffe154
Compare
Merged
|
🎉 This PR is included in version 1.39.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YSP-353: Release Bug: Footer link style
Description of work
Testing Link(s)
Functional Review Steps