Parse pic_struct_present_flag #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arabian9ts
commented
Dec 25, 2024
| sps.Frame_crop_left_offset = bs.ReadUE() // frame_crop_left_offset | ||
| sps.Frame_crop_right_offset = bs.ReadUE() // frame_crop_right_offset | ||
| sps.Frame_crop_top_offset = bs.ReadUE() // frame_crop_top_offset | ||
| sps.Frame_crop_bottom_offset = bs.ReadUE() // frame_crop_bottom_offset |
There was a problem hiding this comment.
The editor will automatically insert spaces. sorry.
arabian9ts
commented
Dec 25, 2024
| @@ -117,6 +117,7 @@ func (sps *SPS) Decode(bs *BitStream) { | |||
| sps.Offset_for_non_ref_pic = bs.ReadSE() // offset_for_non_ref_pic | |||
| sps.Offset_for_top_to_bottom_field = bs.ReadSE() // offset_for_top_to_bottom_field | |||
| num_ref_frames_in_pic_order_cnt_cycle := bs.ReadUE() | |||
| sps.Offset_for_ref_frame = make([]int64, num_ref_frames_in_pic_order_cnt_cycle) | |||
There was a problem hiding this comment.
Here index out of range was occurring so fixed to initialize the slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the great repository!
I'm considering using pic_struct_present_flag for SEI analysis.
The comment in the code states that if BitstreamRestrictionFlag == 1, parsing may fail due to missing bits. However, it is unclear in which specific samples this issue occurs.
At least according to ITU-T H.264 (04/2017), the standard specifically defines both pic_struct_present_flag and bitstream_restriction_flag as 1-bit fields. I think it would be very useful to parse these fields.
https://www.itu.int/itu-t/recommendations/rec.aspx?rec=13189