Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse pic_struct_present_flag #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Parse pic_struct_present_flag #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions go-codec/h264.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,14 @@ func (sps *SPS) Decode(bs *BitStream) {
sps.Profile_idc == 134 || sps.Profile_idc == 135 {
sps.Chroma_format_idc = bs.ReadUE()
if sps.Chroma_format_idc == 3 {
sps.Separate_colour_plane_flag = bs.Uint8(1) //separate_colour_plane_flag
sps.Separate_colour_plane_flag = bs.Uint8(1) // separate_colour_plane_flag
}
sps.Bit_depth_luma_minus8 = bs.ReadUE() //bit_depth_luma_minus8
sps.Bit_depth_chroma_minus8 = bs.ReadUE() //bit_depth_chroma_minus8
bs.SkipBits(1) //qpprime_y_zero_transform_bypass_flag
sps.Bit_depth_luma_minus8 = bs.ReadUE() // bit_depth_luma_minus8
sps.Bit_depth_chroma_minus8 = bs.ReadUE() // bit_depth_chroma_minus8
bs.SkipBits(1) // qpprime_y_zero_transform_bypass_flag
seq_scaling_matrix_present_flag := bs.GetBit()
if seq_scaling_matrix_present_flag == 1 {
//seq_scaling_list_present_flag[i]
// seq_scaling_list_present_flag[i]
if sps.Chroma_format_idc == 3 {
bs.SkipBits(12)
} else {
Expand All @@ -117,6 +117,7 @@ func (sps *SPS) Decode(bs *BitStream) {
sps.Offset_for_non_ref_pic = bs.ReadSE() // offset_for_non_ref_pic
sps.Offset_for_top_to_bottom_field = bs.ReadSE() // offset_for_top_to_bottom_field
num_ref_frames_in_pic_order_cnt_cycle := bs.ReadUE()
sps.Offset_for_ref_frame = make([]int64, num_ref_frames_in_pic_order_cnt_cycle)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here index out of range was occurring so fixed to initialize the slice.

for i := 0; i < int(num_ref_frames_in_pic_order_cnt_cycle); i++ {
sps.Offset_for_ref_frame[i] = bs.ReadSE() // offset_for_ref_frame
}
Expand All @@ -132,10 +133,10 @@ func (sps *SPS) Decode(bs *BitStream) {
sps.Direct_8x8_inference_flag = bs.GetBit()
sps.Frame_cropping_flag = bs.GetBit()
if sps.Frame_cropping_flag == 1 {
sps.Frame_crop_left_offset = bs.ReadUE() //frame_crop_left_offset
sps.Frame_crop_right_offset = bs.ReadUE() //frame_crop_right_offset
sps.Frame_crop_top_offset = bs.ReadUE() //frame_crop_top_offset
sps.Frame_crop_bottom_offset = bs.ReadUE() //frame_crop_bottom_offset
sps.Frame_crop_left_offset = bs.ReadUE() // frame_crop_left_offset
sps.Frame_crop_right_offset = bs.ReadUE() // frame_crop_right_offset
sps.Frame_crop_top_offset = bs.ReadUE() // frame_crop_top_offset
sps.Frame_crop_bottom_offset = bs.ReadUE() // frame_crop_bottom_offset
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The editor will automatically insert spaces. sorry.

}
sps.Vui_parameters_present_flag = bs.GetBit()

Expand Down Expand Up @@ -541,10 +542,11 @@ func (h264Vui *H264VuiParameters) Decode(bs *BitStream) {
h264Vui.LowDelayHrdFlag = bs.Uint8(1)
}

h264Vui.PicStructPresentFlag = bs.GetBit()
h264Vui.BitstreamRestrictionFlag = bs.GetBit()

/*
TODO - These fields were causing problems because we'd run out of bits when parsing. Maybe they're optional in certain versions/levels/configurations?
h264Vui.PicStructPresentFlag = bs.GetBit()
h264Vui.BitstreamRestrictionFlag = bs.GetBit()

if h264Vui.BitstreamRestrictionFlag == 1 {
h264Vui.MotionVectorsOverPicBoundaries = bs.GetBit()
Expand Down