Fix sizeBytesToRequest in case if no request has been done #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
============================================
- Coverage 44.39% 44.37% -0.03%
Complexity 1571 1571
============================================
Files 297 297
Lines 11505 11506 +1
Branches 1124 1124
============================================
- Hits 5108 5106 -2
- Misses 5988 5991 +3
Partials 409 409 ☔ View full report in Codecov by Sentry. |
pnv1
reviewed
Jun 5, 2024
| @@ -259,6 +259,7 @@ private void sendReadRequest() { | |||
| if (currentSizeBytesToRequest <= 0) { | |||
| logger.debug("[{}] Nothing to request in DataRequest. sizeBytesToRequest == {}", fullId, | |||
| currentSizeBytesToRequest); | |||
| sizeBytesToRequest.addAndGet(currentSizeBytesToRequest); | |||
There was a problem hiding this comment.
Negative size is unreal afaik.
Zero is pretty possible in case of race condition between two threads.
Fix is kinda paranoic but OK.
I'd check for zero before modifying Atomic member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.