Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sizeBytesToRequest in case if no request has been done #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sizeBytesToRequest in case if no request has been done #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions topic/src/main/java/tech/ydb/topic/read/impl/ReaderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ private void sendReadRequest() {
if (currentSizeBytesToRequest <= 0) {
logger.debug("[{}] Nothing to request in DataRequest. sizeBytesToRequest == {}", fullId,
currentSizeBytesToRequest);
sizeBytesToRequest.addAndGet(currentSizeBytesToRequest);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative size is unreal afaik.
Zero is pretty possible in case of race condition between two threads.
Fix is kinda paranoic but OK.
I'd check for zero before modifying Atomic member

return;
}
logger.debug("[{}] Sending DataRequest with {} bytes", fullId, currentSizeBytesToRequest);
Expand Down