Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unnecessary argument $rawSql of AbstractCommand::internalExecute() #778

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 17, 2023

The optimization also removes extra call $this->getRawSql().

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6845a40) 99.64% compared to head (af12398) 99.64%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #778   +/-   ##
=========================================
  Coverage     99.64%   99.64%           
  Complexity     1272     1272           
=========================================
  Files            63       63           
  Lines          3061     3061           
=========================================
  Hits           3050     3050           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 17, 2023

PR Summary

  • Resolved Issue with Query Counting
    The team spotted a bug (Fix query count #777) which affected the counting functionality Query::count(). This issue would result in incorrect values if the result was greater than the maximum integer value the system could handle. It's now been fixed, enhancing the accuracy and reliability of count operations in our service.

  • Depreciation and Modification of Arguments in Command Files
    Unnecessary arguments can complicate code structure. So, in an effort to simplify and streamline, the argument $rawSql in AbstractCommand::internalExecute() was deemed unnecessary and thus depreciated. Going forward, $rawSql should be set to null. This change will take full effect in version 2.0.0. A similar change was made in the 'AbstractPdoCommand' file - AbstractPdoCommand::execute(). This framing will help keep the process more intuitive while using these commands.

@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 17, 2023
@Tigrov Tigrov changed the title Remove unnecessary argument $rawSql of AbstractCommand::internalExecute() Deprecate unnecessary argument $rawSql of AbstractCommand::internalExecute() Nov 17, 2023
@Tigrov Tigrov requested a review from a team November 17, 2023 03:26
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line to changelog only

@vjik vjik merged commit 102ee3a into master Nov 21, 2023
87 of 89 checks passed
@vjik vjik deleted the remove-unnecessary-argument branch November 21, 2023 13:52
@what-the-diff what-the-diff bot mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants