Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unnecessary argument $rawSql of AbstractCommand::internalExecute() #778

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Deprecate unnecessary argument $rawSql of AbstractCommand::internalExecute() #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfeb83e
Remove unnecessary argument `$rawSql` of `AbstractCommand::internalEx…
Tigrov Nov 17, 2023
af12398
Add line to CHANGELOG.md
Tigrov Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## 1.2.1 under development

- Bug #777: Fix `Query::count()` when it returns an incorrect value if the result is greater
than `PHP_INT_MAX` (@Tigrov)
- Bug #777: Fix `Query::count()` when it returns an incorrect value if the result is greater than `PHP_INT_MAX` (@Tigrov)
- Enh #778: Deprecate unnecessary argument `$rawSql` of `AbstractCommand::internalExecute()` (@Tigrov)

## 1.2.0 November 12, 2023

Expand Down
4 changes: 2 additions & 2 deletions src/Command/AbstractCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ abstract protected function internalGetQueryResult(int $queryMode): mixed;
/**
* Executes a prepared statement.
*
* @param string|null $rawSql The rawSql if it has been created.
* @param string|null $rawSql Deprecated. Use `null` value. Will be removed in version 2.0.0.
*
* @throws Exception
* @throws Throwable
Expand Down Expand Up @@ -581,7 +581,7 @@ protected function queryInternal(int $queryMode): mixed
$isReadMode = $this->isReadMode($queryMode);
$this->prepare($isReadMode);

$this->internalExecute($this->getRawSql());
$this->internalExecute(null);

/** @psalm-var mixed $result */
$result = $this->internalGetQueryResult($queryMode);
Expand Down
2 changes: 1 addition & 1 deletion src/Driver/Pdo/AbstractPdoCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ protected function getQueryMode(int $queryMode): string
*
* It's a wrapper around {@see PDOStatement::execute()} to support transactions and retry handlers.
*
* @param string|null $rawSql The rawSql if it has been created.
* @param string|null $rawSql Deprecated. Use `null` value. Will be removed in version 2.0.0.
*
* @throws Exception
* @throws Throwable
Expand Down
Loading