-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update presence design document #609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 51.19% 50.24% -0.96%
==========================================
Files 67 69 +2
Lines 7053 7314 +261
==========================================
+ Hits 3611 3675 +64
- Misses 2960 3147 +187
- Partials 482 492 +10
|
hackerwins
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left a minor comment.
hackerwins
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Update pub-sub design document * Rename peer awareness to presence
This was referenced Aug 18, 2023
Wu22e
pushed a commit
to Wu22e/yorkie
that referenced
this pull request
Sep 3, 2023
* Update pub-sub design document * Rename peer awareness to presence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update design document for presence.
It contains information about the changes made in the following pull request.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
While working on the document, I think it is better to make the following changes. (I will address these changes through a separate pull request):
WatchDocument
API has been updated to operate on a single document: Add RemoveDocument API yorkie-js-sdk#480).doc.getPresences()
todoc.getUsers()
(as the returned value aligns more closely with user information, making this name easier to comprehend).Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: