Shard unit tests #4666
Merged
Shard unit tests #4666
+77
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imindich
force-pushed
the
experimental/sharding
branch
from
cf71d1c to
01889e2
Compare
…atterns to pick up the files when downloading.
isarkis
reviewed
Jan 10, 2025
imindich
force-pushed
the
experimental/sharding
branch
from
d33bf2a to
9cbef37
Compare
isarkis
approved these changes
Jan 10, 2025
imindich
force-pushed
the
experimental/sharding
branch
from
6cbffe0 to
9dd423e
Compare
oxve
approved these changes
Jan 14, 2025
imindich
force-pushed
the
experimental/sharding
branch
from
d2b587a to
c27ed29
Compare
imindich
force-pushed
the
experimental/sharding
branch
from
e0028ea to
f8c1b48
Compare
imindich
force-pushed
the
experimental/sharding
branch
from
458604f to
cc79e52
Compare
imindich
force-pushed
the
experimental/sharding
branch
from
9ca2796 to
04b8df8
Compare
isarkis
reviewed
Jan 15, 2025
…not need GCS access.
imindich
force-pushed
the
experimental/sharding
branch
from
6c0ea03 to
95a41c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/388125345
Run unit tests on linux using 10 shards. Each gtest binary is split up across all shards, and results are aggregated and reported in the test reporting job.
Using 10 shards, each shard takes <= 2 minutes 10 seconds to complete: https://github.com/youtube/cobalt/actions/runs/12681753920/job/35346881410?pr=4666
Running tests without sharding currently takes ~5 minutes 30 seconds: https://github.com/youtube/cobalt/actions/runs/12679757749/job/35341306163?pr=4667
If num_shards is not specified in a config json, the number of shards defaults to 1.