Code

Shard unit tests#4666

Code

Merged

imindich merged 32 commits intomainyoutube/cobalt:mainfrom experimental/shardingyoutube/cobalt:experimental/shardingCopy head branch name to clipboardJan 15, 2025

+77-17

Commits

Commits on Jan 8, 2025

• Split up test running and test reporting into separate jobs.

  imindich

  committed
  91ad8f4

  Copy full SHA for 91ad8f4

• indenting

  imindich

  committed
  33d2030

  Copy full SHA for 33d2030

• Split up test binaries across 5 shards

  imindich

  committed
  a672f68

  Copy full SHA for a672f68

• Add base_unittests

  imindich

  committed
  476d3b6

  Copy full SHA for 476d3b6

• Make artifact names unique based on shard

  imindich

  committed
  ff27fc7

  Copy full SHA for ff27fc7

• Try 6 shards, 5 shards taking ~57 seconds to run tests

  imindich

  committed
  902d80c

  Copy full SHA for 902d80c

• Increase shard count to 10.

  imindich

  committed
  e2efd64

  Copy full SHA for e2efd64

• Add back all test targets

  imindich

  committed
  4f16ae1

  Copy full SHA for 4f16ae1

• Process test results regardless of test job outcome.

  imindich

  committed
  01889e2

  Copy full SHA for 01889e2

• Include shard number in test steps.

  imindich

  committed
  122792a

  Copy full SHA for 122792a

• Ensure files uploaded by each shard have unique paths, and use glob patterns to pick up the files when downloading.

  imindich

  committed
  02a217b

  Copy full SHA for 02a217b

• Populate num shards from yaml configs.

  imindich

  committed
  b1a8963

  Copy full SHA for b1a8963

• Add missing checkout step to test upload job.

  imindich

  committed
  40417f8

  Copy full SHA for 40417f8

• Update xml path to write test results to the correct location.

  imindich

  committed
  543e744

  Copy full SHA for 543e744

• call FromJson for array

  imindich

  committed
  c5e7b40

  Copy full SHA for c5e7b40

Commits on Jan 9, 2025

• Make artifact names unique, and download artifacts according to a pattern

  imindich

  committed
  39d2b38

  Copy full SHA for 39d2b38

Commits on Jan 10, 2025

• Undo whitespace change.

  imindich

  committed
  bef8869

  Copy full SHA for bef8869

• Rename variables num_shards=>num_gtest_shards, shards=>gtest_shards.

  imindich

  committed
  e109e44

  Copy full SHA for e109e44

• Include GITHUB_WORKSPACE when retrieving num-shards from config file to be consistent.

  imindich

  committed
  9cbef37

  Copy full SHA for 9cbef37

• Add if always() to test upload job to still run when test executor job fails.

  imindich

  committed
  a5befe8

  Copy full SHA for a5befe8

• Add comment for fallback command

  imindich

  committed
  a73be93

  Copy full SHA for a73be93

Commits on Jan 14, 2025

• Add a single job validate-test-result that will fail will be used to gate pr merges

  imindich

  committed
  9dd423e

  Copy full SHA for 9dd423e

• Update verbose job prerequisites.

  imindich

  committed
  e10e952

  Copy full SHA for e10e952

• Add if: always() to ensure validate test result job runs.

  imindich

  committed
  c27ed29

  Copy full SHA for c27ed29

• delete base unittests filter to test validate tests step will fail.

  imindich

  committed
  f8c1b48

  Copy full SHA for f8c1b48

• Add condition to run test validation job iff testing is enabled.

  imindich

  committed
  f2031fc

  Copy full SHA for f2031fc

• Add back base_unittests filter entries since tests passing job failed as expected.

  imindich

  committed
  5cc7a33

  Copy full SHA for 5cc7a33

• Only validate test results for on-host tests

  imindich

  committed
  cc79e52

  Copy full SHA for cc79e52

Commits on Jan 15, 2025

• Validate test results for on-device-tests if its specified in the config.

  imindich

  committed
  f0fd861

  Copy full SHA for f0fd861

• Remove test-on-device:true from android configs since its not being used.

  imindich

  committed
  04b8df8

  Copy full SHA for 04b8df8

• Change test validation job to run on a hosted runner because it does not need GCS access.

  imindich

  committed
  95a41c1

  Copy full SHA for 95a41c1

• Merge branch 'main' into experimental/sharding

  imindich

  authored
  4766499

  Copy full SHA for 4766499