TYP: hotfix unsolvable type-checking requirements #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
hotfix_typechecking
branch
from
4c9f625
to
ef4f915
Compare
neutrinoceros
force-pushed
the
hotfix_typechecking
branch
from
ef4f915
to
50143ba
Compare
|
I have to run so I ignored the one new failure for lack of time |
|
that windows failure is from the latest h5py release, see h5py/h5py#2505 I'll adjust the test requirements to avoid it (and push up to this PR) |
|
oh, err. maybe that wasn't the right move. cause now h5py will be installed in every test environment, including the minimal test which it shouldn't be... I'm going to let tests run then move the h5py exclusion up to the hdf5 install option. |
Xarthisius
approved these changes
Sep 25, 2024
|
thanks Chris and Kacper for finishing this ! FYI h5py 3.12.0 is now yanked from PyPI and I'll be looking into what happened with that release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Hotfix a problem I just created by merging #4989 (which apparently didn't run typechecking at all)
example logs