Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: hotfix unsolvable type-checking requirements #5008

Merged
merged 4 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/type-checking.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ on:
pull_request:
paths:
- yt/**/*.py
- setup.cfg
- pyproject.toml
- requirements/typecheck.txt
- .github/workflows/type-checking.yaml
workflow_dispatch:

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ answer-testing = "yt.utilities.answer_testing.framework:AnswerTesting"

[project.optional-dependencies]
# some generic, reusable constraints on optional-deps
HDF5 = ["h5py>=3.1.0"]
HDF5 = ["h5py>=3.1.0,!=3.12.0; platform_system=='Windows'"] # see https://github.com/h5py/h5py/issues/2505
netCDF4 = ["netCDF4!=1.6.1,>=1.5.3"] # see https://github.com/Unidata/netcdf4-python/issues/1192
Fortran = ["f90nml>=1.1"]

Expand Down
2 changes: 1 addition & 1 deletion requirements/typecheck.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ mypy==1.11.2
types-PyYAML==6.0.12.20240808
types-chardet==5.0.4.6
types-requests==2.32.0.20240907
typing-extensions==4.4.0; python_version < '3.12'
typing-extensions==4.6.0; python_version < '3.12'
2 changes: 1 addition & 1 deletion yt/data_objects/construction_data_containers.py
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,7 @@ class YTSmoothedCoveringGrid(YTCoveringGrid):
filename = None
_min_level = None

@wraps(YTCoveringGrid.__init__)
@wraps(YTCoveringGrid.__init__) # type: ignore [misc]
def __init__(self, *args, **kwargs):
ds = kwargs["ds"]
self._base_dx = (
Expand Down
Loading