Added change in the installer script for rhel9 installation #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivanshGahlot
requested review from
shubham-yb,
priyanshi-yb and
sanyamsinghal
sanyamsinghal
approved these changes
Feb 17, 2025
Comment on lines
+913
to
916
| if [ "$version" -eq 8 ]; then | ||
| $YUM_INSTALL mysql-devel 1>&2 | ||
| return | ||
| fi |
There was a problem hiding this comment.
@ShivanshGahlot Does it makes sense to tie version here for mysql client packages in yum command.
like - $YUM_INSTALL mysql-devel@version 1>&2
There was a problem hiding this comment.
Hmm, we haven't ever faced a problem wrt the version of mysql-devel have we? I don't think its really needed I guess?
There was a problem hiding this comment.
Got it, i confused the version here(centos version) with mysql version
sanyamsinghal
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Added change in the installer script for rhel9 installation
Why was it required?
The mysql-devel package is not availble on rhel9. So we are installing mysql-community-devel in case of rhel9. Therefore, the mysql-devel package is only limited to rhel8 now.
Describe if there are any user-facing changes
No
How was this pull request tested?
Jenkins
Does your PR have changes that can cause upgrade issues?