Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added change in the installer script for rhel9 installation #2327

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Added change in the installer script for rhel9 installation #2327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea20fe
Changes for mysql-devel
ShivanshGahlot Jan 22, 2025
4c089d2
Changes for mysql-devel
ShivanshGahlot Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions installer_scripts/install-yb-voyager
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,8 +909,8 @@ create_guardrail_scripts_dir() {

centos_install_mysql_client() {
version=$1
# If version is greater than or equal to 8 then dont install from community repo
if [ "$version" -ge 8 ]; then
# If version is equal to 8 then dont install from community repo
if [ "$version" -eq 8 ]; then
$YUM_INSTALL mysql-devel 1>&2
return
fi
Comment on lines +913 to 916
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShivanshGahlot Does it makes sense to tie version here for mysql client packages in yum command.
like - $YUM_INSTALL mysql-devel@version 1>&2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we haven't ever faced a problem wrt the version of mysql-devel have we? I don't think its really needed I guess?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, i confused the version here(centos version) with mysql version

Expand All @@ -919,6 +919,7 @@ centos_install_mysql_client() {
sudo yum remove -y mysql84-community-release-el${version}-1 1>&2
sudo yum install -y mysql84-community-release-el${version}-1.noarch.rpm 1>&2
sudo yum install -y mysql-community-devel 1>&2
rm -f mysql84-community-release-el${version}-1.noarch.rpm
}

centos_check_base_repo_enabled() {
Expand Down
Loading