Support separate subnets for LBs and workers #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
added
minor
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
split-lb-worker-subnets
branch
from
a17482f
to
11a2828
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
1 task
| subnetsValueKey: azInfoWorkers.SubnetsByAZ(), | ||
| availabilityZonesValueKey: azInfoWorkers.AvailabilityZones(), | ||
| subnetIPV6CIDRsKey: strings.Join(azInfoWorkers.SubnetIPv6CIDRs(), ","), | ||
| "lb_subnets": azInfoLBs.SubnetsByAZ(), |
There was a problem hiding this comment.
This is new, do we need in a similar change in provisionNodePool ?
There was a problem hiding this comment.
I guess this is handled by azInfo: azInfoWorkers change.
There was a problem hiding this comment.
This will be used like this: zalando-incubator/kubernetes-on-aws#8440
|
👍 |
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
|
👍 |
|
This change require that we set I have tested what happens if we should have forgotten to set the tags in an existing cluster. The CF stack fails with:
And rolls back without disruption. So there is no impact if it should be the case. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for choosing different subnets for running Load Balancers and nodes. Until now they all used the same subnets leading to challenges when wanting to use different ingress and egress rules.
The subnets are selected based on tags:
kubernetes.io/role/elbkubernetes.io/role/nodeFor safe roll out, we will first add the
kubernetes.io/role/nodetag to existing subnets with the tag:kubernetes.io/role/elbsuch that there is no change for running clusters as a change will require a migration.