Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to separate subnets for LBs and nodes #8440

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

mikkeloscar
Copy link
Contributor

@mikkeloscar mikkeloscar commented Oct 25, 2024

Allows to have separate subnets for LBs and for nodes which enables different rules for ingress and egress.

Existing clusters will continue to use the same subnets for both. A migration is needed to split it.

@mikkeloscar mikkeloscar added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Oct 25, 2024
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
@zalando-robot
Copy link

zalando-robot commented Oct 28, 2024

Deployment Checklist

This change falls under our deployment policy. Would you call it low-risk? If so, please check this box:

  • This is a low-risk change: a feature change or update behind a feature toggle, a minor change, a bug fix, or a patch. It is unlikely to disrupt services, or can be rolled back very quickly (feature toggle).

💁 If this is not a low-risk change, please confirm all of the following requirements:

  • Detailed release notes are provided in this PR’s description.
  • Thorough load-testing has been performed (link).
  • Technical review: Principal Engineers or Tech Leads have green-lit your changes (link).
  • You can enable/disable the change via feature toggles, and have confirmed these toggles work as expected.
  • Management approval is given by … (Engineering Manager or above).

👉 Regardless of which boxes you click in this comment, merge/deployment will not be blocked (though it’ll be included in cyber week reporting).

@mikkeloscar
Copy link
Contributor Author

👍

1 similar comment
@demonCoder95
Copy link
Member

👍

@demonCoder95 demonCoder95 merged commit 57defdd into dev Oct 28, 2024
10 checks passed
@demonCoder95 demonCoder95 deleted the unique-lb-subnets branch October 28, 2024 14:27
This was referenced Oct 28, 2024
@k8s-on-aws-manager-app k8s-on-aws-manager-app bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/alpha merged/beta merged/eks merged/stable minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants