Feature/sidepanel support and flow [WLT-5590] #617
Conversation
|
📦 build.zip [updated at Oct 28, 3:42:29 PM UTC] |
everdimension
force-pushed
the
feature/sidepanel-support-and-flow
branch
2 times, most recently
from
5fe3af4
to
1cb262e
Compare
| @@ -39,6 +39,7 @@ body { | |||
| */ | |||
| display: grid; | |||
| --body-width: 425px; | |||
| --body-max-width: 800px; | |||
There was a problem hiding this comment.
should we add this to popup mode too?
also login page layout is a bit broken on wide screen
There was a problem hiding this comment.
Popup can't be this wide
| @@ -42,18 +46,33 @@ export const sessionCacheService = new PortMessageChannel({ | |||
| }) as RPCPort<SessionCacheService>; | |||
|
|
|||
| class WindowPort extends PortMessageChannel { | |||
| static maybeRestoreRouteForSidepanel() { | |||
| if (urlContext.windowType === 'sidepanel') { | |||
| // TODO: navigate to location that user was on before opening the request view? | |||
There was a problem hiding this comment.
Should we implement this before release?
src/background/Wallet/Wallet.ts
Outdated
| @@ -1631,6 +1639,10 @@ class PublicController { | |||
| origin: string, | |||
| props: NotificationWindowProps<T> | |||
| ) { | |||
| if (debugValue && process.env.NODE_ENV === 'development') { | |||
src/shared/UrlContext.ts
Outdated
| windowType: | ||
| (params.get(UrlContextParam.windowType) as WindowType) || 'popup', | ||
| windowType: getWindowType(params), | ||
| // (params.get(UrlContextParam.windowType) as WindowType) || 'popup', |
| @@ -6,12 +6,19 @@ import type { | |||
| } from './types/UrlContext'; | |||
| import { UrlContextParam } from './types/UrlContext'; | |||
|
|
|||
| function getWindowType(params: URLSearchParams): WindowType { | |||
| if (window.location.pathname.startsWith('/sidepanel')) { | |||
There was a problem hiding this comment.
Do we use this case somewhere?
There was a problem hiding this comment.
yes, we use urlContext.windowType in a lot of places :)
| @@ -715,7 +715,10 @@ function SendTransactionContent({ | |||
| const windowId = params.get('windowId'); | |||
| invariant(windowId, 'windowId get-parameter is required'); | |||
| windowPort.reject(windowId); | |||
| navigate(-1); | |||
| // navigate(-1); | |||
src/shared/sidepanel/types.ts
Outdated
| @@ -0,0 +1,21 @@ | |||
| import { isObj } from '../isObj'; | |||
|
|
|||
| interface IsOpenRequest { | |||
| export function isSidepanelMessageRequest( | ||
| x: unknown | ||
| ): x is SidepanelMessageRequest { | ||
| return isObj(x) && isObj(x.payload) && 'method' in x.payload; |
There was a problem hiding this comment.
should we check here that x.payload.method is one of options 'is-sidepanel-open'/'close-sidepanel'?
There was a problem hiding this comment.
This would make it harder to add more methods
Good case for zod btw
| @@ -0,0 +1,3 @@ | |||
| export function isSidepanelSupported() { | |||
| return globalThis.chrome && 'sidePanel' in chrome; | |||
There was a problem hiding this comment.
This is a canonical way to check for browser apis
There's no reason for the property to exist and be nullish, I think. And we're not checking deeper anyway
| export async function openSidePanel({ | ||
| pathname, | ||
| searchParams, | ||
| openOptions, |
| // const id = nanoid(); | ||
| // searchParams.append('windowId', String(id)); | ||
| // We use HashRouter currently | ||
| if (searchParams) { |
There was a problem hiding this comment.
As I see there is only one case of this function call and searchParams are always null
There was a problem hiding this comment.
This is still a reasonable api I think
everdimension
force-pushed
the
feature/sidepanel-support-and-flow
branch
2 times, most recently
from
e948e7f
to
c27f582
Compare
React to active tab change, URL change and dapp chain change
Refactor NotificationWindow to handle sidepanel and edge cases such as multiple windows opened where some have sidepanel opened and some don't
everdimension
force-pushed
the
feature/sidepanel-support-and-flow
branch
from
c27f582
to
92d5d7c
Compare
No description provided.