Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Object and derived classes use SharedPtr with the Original mapping #1668

Merged
merged 11 commits into from
Jan 15, 2024

Conversation

bernardnormier
Copy link
Member

This PR changes ObjectPtr to be a SharedPtr with the Original mapping. It's the first step in making the same Ice::Object the common Object base class for the Original and New mappings.

You'll notice:

  • there are few C++ updates, especially test updates, which is good as it shows this update is largely source compatible
  • the updates are mostly related to "this" sharing
  • there was no update to PHP and Ruby, and minimal updates to Python
  • unfortunately Objective-C required more updates as it was overwriting IceUtil::Shared __incRef and __decRef.

objective-c/src/Ice/Object.mm Outdated Show resolved Hide resolved
objective-c/src/Ice/PropertiesI.mm Show resolved Hide resolved
Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bernardnormier bernardnormier merged commit 2c997fb into zeroc-ice:main Jan 15, 2024
16 of 17 checks passed
@bernardnormier bernardnormier deleted the common-object branch May 10, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants