-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port 3.1.0 release changes to main #3421
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
* fix: Avoid data-loss when creating new members (#3392) * fix: Prompt users when creating members if the member exists Signed-off-by: Fernando Rijo Cedeno <[email protected]> * review: alternative way Signed-off-by: Fernando Rijo Cedeno <[email protected]> * test: add coverage for added memberFound logic Signed-off-by: Fernando Rijo Cedeno <[email protected]> * chore: update changelog Signed-off-by: Fernando Rijo Cedeno <[email protected]> * chore: cleanup commented code Signed-off-by: Fernando Rijo Cedeno <[email protected]> * chore: simplify fix 😋 Signed-off-by: Fernando Rijo Cedeno <[email protected]> * Update packages/zowe-explorer/CHANGELOG.md Co-authored-by: Trae Yelovich <[email protected]> Signed-off-by: Fernando Rijo Cedeno <[email protected]> --------- Signed-off-by: Fernando Rijo Cedeno <[email protected]> Co-authored-by: Trae Yelovich <[email protected]> * chore: move the changelog entry to the right location Signed-off-by: Fernando Rijo Cedeno <[email protected]> --------- Signed-off-by: Fernando Rijo Cedeno <[email protected]> Co-authored-by: Trae Yelovich <[email protected]>
…3416) * Fix internal error when extenders register new profile types (#3412) Signed-off-by: Timothy Johnson <[email protected]> Signed-off-by: Fernando Rijo Cedeno <[email protected]> * chore: downgrade ubuntu runners to ubuntu-22.04 (#3406) Signed-off-by: Trae Yelovich <[email protected]> --------- Signed-off-by: Timothy Johnson <[email protected]> Signed-off-by: Fernando Rijo Cedeno <[email protected]> Signed-off-by: Trae Yelovich <[email protected]> Co-authored-by: Timothy Johnson <[email protected]> Co-authored-by: Trae Yelovich <[email protected]>
* update lerna and remove un-needed changelog headers Signed-off-by: Billie Simmons <[email protected]> * add notes to readme's of VSC for older releases location with link Signed-off-by: Billie Simmons <[email protected]> * run package command Signed-off-by: Billie Simmons <[email protected]> * chore: downgrade ubuntu runners to ubuntu-22.04 Signed-off-by: Trae Yelovich <[email protected]> * fix: call Mutex.waitForUnlock instead of locking profile before request (#3409) * fix: call Mutex.waitForUnlock instead of locking profile before request Signed-off-by: Trae Yelovich <[email protected]> * fix: AuthHandler.waitForUnlock Signed-off-by: Trae Yelovich <[email protected]> * tests: AuthHandler.waitForUnlock Signed-off-by: Trae Yelovich <[email protected]> * fix: add true opt-in support for profile locks w/ extender types Signed-off-by: Trae Yelovich <[email protected]> --------- Signed-off-by: Trae Yelovich <[email protected]> * fix(ds): Pass correct DS name in `stat` when doing remote lookup (#3407) * fix: use path.basename and helper fn to extract DS name Signed-off-by: Trae Yelovich <[email protected]> * test: add unit test to verify proper DS name Signed-off-by: Trae Yelovich <[email protected]> * chore: update changelog Signed-off-by: Trae Yelovich <[email protected]> --------- Signed-off-by: Trae Yelovich <[email protected]> Co-authored-by: Timothy Johnson <[email protected]> Signed-off-by: Timothy Johnson <[email protected]> --------- Signed-off-by: Billie Simmons <[email protected]> Signed-off-by: Trae Yelovich <[email protected]> Signed-off-by: Timothy Johnson <[email protected]> Signed-off-by: Fernando Rijo Cedeno <[email protected]> Co-authored-by: Trae Yelovich <[email protected]> Co-authored-by: Timothy Johnson <[email protected]> Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: zowe-robot <[email protected]>
Signed-off-by: zowe-robot <[email protected]>
📅 Suggested merge-by date: 2/11/2025 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3421 +/- ##
==========================================
+ Coverage 93.18% 93.20% +0.01%
==========================================
Files 120 120
Lines 12582 12582
Branches 2890 2779 -111
==========================================
+ Hits 11725 11727 +2
+ Misses 856 854 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
b4e19a8
to
51c5b2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
I approved this but then realized a test is failing on the Windows stages. I'm not sure why this is the case if tests are passing on |
Signed-off-by: Fernando Rijo Cedeno <[email protected]> Third-Party DCO Remediation Commit for Billie Simmons <[email protected]> On behalf of Billie Simmons <[email protected]>, I, Fernando Rijo Cedeno <[email protected]>, hereby add my Signed-off-by to this commit: 0efa5bb Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Fixed in 57e1e37 It seems like there may be an issue with the Windows GitHub runner - when I run tests locally for this branch, it works fine. (both the fixed test & all tests using |
Signed-off-by: Trae Yelovich <[email protected]>
f7d68f1
to
57e1e37
Compare
Thanks @traeok I was looking into commits across main and release/3.1 but didn't see other PRs failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Proposed changes
Port 3.1.0 release updating changelogs & lerna for 3.2.0 work
Release Notes
Milestone: n/a
Changelog: n/a
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments