Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 3.1.0 release changes to main #3421

Merged
merged 12 commits into from
Feb 3, 2025
Merged

Port 3.1.0 release changes to main #3421

merged 12 commits into from
Feb 3, 2025

Conversation

JillieBeanSim
Copy link
Contributor

Proposed changes

Port 3.1.0 release updating changelogs & lerna for 3.2.0 work

Release Notes

Milestone: n/a

Changelog: n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

traeok and others added 7 commits January 14, 2025 11:03
Signed-off-by: Trae Yelovich <[email protected]>
* fix: Avoid data-loss when creating new members (#3392)

* fix: Prompt users when creating members if the member exists

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* review: alternative way

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* test: add coverage for added memberFound logic

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: update changelog

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: cleanup commented code

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: simplify fix 😋

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>

* chore: move the changelog entry to the right location

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
…3416)

* Fix internal error when extenders register new profile types (#3412)

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: downgrade ubuntu runners to ubuntu-22.04 (#3406)

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
* update lerna and remove un-needed changelog headers

Signed-off-by: Billie Simmons <[email protected]>

* add notes to readme's of VSC for older releases location with link

Signed-off-by: Billie Simmons <[email protected]>

* run package command

Signed-off-by: Billie Simmons <[email protected]>

* chore: downgrade ubuntu runners to ubuntu-22.04

Signed-off-by: Trae Yelovich <[email protected]>

* fix: call Mutex.waitForUnlock instead of locking profile before request (#3409)

* fix: call Mutex.waitForUnlock instead of locking profile before request

Signed-off-by: Trae Yelovich <[email protected]>

* fix: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* tests: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* fix: add true opt-in support for profile locks w/ extender types

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* fix(ds): Pass correct DS name in `stat` when doing remote lookup (#3407)

* fix: use path.basename and helper fn to extract DS name

Signed-off-by: Trae Yelovich <[email protected]>

* test: add unit test to verify proper DS name

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update changelog

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]>
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Jan 28, 2025
@JillieBeanSim JillieBeanSim self-assigned this Jan 28, 2025
@JillieBeanSim JillieBeanSim changed the title Port 3.1.0 release Port 3.1.0 release changes to main Jan 28, 2025
Copy link

📅 Suggested merge-by date: 2/11/2025

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (96370ae) to head (57e1e37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3421      +/-   ##
==========================================
+ Coverage   93.18%   93.20%   +0.01%     
==========================================
  Files         120      120              
  Lines       12582    12582              
  Branches     2890     2779     -111     
==========================================
+ Hits        11725    11727       +2     
+ Misses        856      854       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JTonda JTonda requested review from zFernand0 and traeok January 30, 2025 16:07
@JillieBeanSim JillieBeanSim force-pushed the chore/port-3.1.0-release branch from b4e19a8 to 51c5b2a Compare January 31, 2025 14:19
zFernand0
zFernand0 previously approved these changes Jan 31, 2025
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

traeok
traeok previously approved these changes Jan 31, 2025
@traeok
Copy link
Member

traeok commented Jan 31, 2025

I approved this but then realized a test is failing on the Windows stages. I'm not sure why this is the case if tests are passing on main, but I can file an issue to track this

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

Third-Party DCO Remediation Commit for Billie Simmons <[email protected]>

On behalf of Billie Simmons <[email protected]>, I, Fernando Rijo Cedeno <[email protected]>, hereby add my Signed-off-by to this commit: 0efa5bb

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
@zFernand0 zFernand0 dismissed stale reviews from traeok and themself via 21ce399 January 31, 2025 14:56
@traeok
Copy link
Member

traeok commented Jan 31, 2025

I approved this but then realized a test is failing on the Windows stages. I'm not sure why this is the case if tests are passing on main, but I can file an issue to track this

Fixed in 57e1e37

It seems like there may be an issue with the Windows GitHub runner - when I run tests locally for this branch, it works fine. (both the fixed test & all tests using pnpm test)

@traeok traeok force-pushed the chore/port-3.1.0-release branch from f7d68f1 to 57e1e37 Compare January 31, 2025 15:35
@traeok traeok requested review from zFernand0 and t1m0thyj January 31, 2025 16:29
@JillieBeanSim
Copy link
Contributor Author

Thanks @traeok I was looking into commits across main and release/3.1 but didn't see other PRs failing

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit 54044bf into main Feb 3, 2025
25 checks passed
@zFernand0 zFernand0 deleted the chore/port-3.1.0-release branch February 3, 2025 18:25
@JillieBeanSim JillieBeanSim mentioned this pull request Feb 5, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/M
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants