Update dockerfile in consensus module to use renv #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjspielman
reviewed
Dec 17, 2024
| # A template docker file for creating a new analysis | ||
| FROM ubuntu:22.04 | ||
| # Dockerfile for cell-type-consensus module | ||
| FROM bioconductor/r-ver:3.20 |
There was a problem hiding this comment.
noting we probably want 3.19 which is our preferred OpenScPCA-wide version.
There was a problem hiding this comment.
Based on this comment we are okay with 3.20 here.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm just filling out the Dockerfile for
cell-type-consensusto create the image for this module. I also cherry picked the commits from #936 to run the GHA to build this image and all the relevant changes to the lock file.I think we want to do this first and then I can adjust the workflow in #936 to use this image rather than trying to set up
renvin CI. I believe this should help solve our igraph problems.I tested building this locally and didn't have any issues.