Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile in consensus module to use renv #950

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/docker_all-modules.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
- cell-type-wilms-tumor-14
- cell-type-nonETP-ALL-03
- cell-type-ETP-ALL-03
- cell-type-consensus
uses: ./.github/workflows/build-push-docker-module.yml
if: github.repository_owner == 'AlexsLemonade'
with:
Expand Down
32 changes: 16 additions & 16 deletions .github/workflows/docker_cell-type-consensus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@ concurrency:
cancel-in-progress: true

on:
# pull_request:
# branches:
# - main
# paths:
# - "analyses/cell-type-consensus/Dockerfile"
# - "analyses/cell-type-consensus/.dockerignore"
# - "analyses/cell-type-consensus/renv.lock"
# - "analyses/cell-type-consensus/conda-lock.yml"
# push:
# branches:
# - main
# paths:
# - "analyses/cell-type-consensus/Dockerfile"
# - "analyses/cell-type-consensus/.dockerignore"
# - "analyses/cell-type-consensus/renv.lock"
# - "analyses/cell-type-consensus/conda-lock.yml"
pull_request:
branches:
- main
paths:
- "analyses/cell-type-consensus/Dockerfile"
- "analyses/cell-type-consensus/.dockerignore"
- "analyses/cell-type-consensus/renv.lock"
- "analyses/cell-type-consensus/conda-lock.yml"
push:
branches:
- main
paths:
- "analyses/cell-type-consensus/Dockerfile"
- "analyses/cell-type-consensus/.dockerignore"
- "analyses/cell-type-consensus/renv.lock"
- "analyses/cell-type-consensus/conda-lock.yml"
workflow_dispatch:
inputs:
push-ecr:
Expand Down
36 changes: 33 additions & 3 deletions analyses/cell-type-consensus/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,40 @@
# A template docker file for creating a new analysis
FROM ubuntu:22.04
# Dockerfile for cell-type-consensus module
FROM bioconductor/r-ver:3.20

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting we probably want 3.19 which is our preferred OpenScPCA-wide version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this comment we are okay with 3.20 here.

# Labels following the Open Containers Initiative (OCI) recommendations
# For more information, see https://specs.opencontainers.org/image-spec/annotations/?v=v1.0.1
LABEL org.opencontainers.image.title="openscpca/cell-type-consensus"
LABEL org.opencontainers.image.description="Docker image for the OpenScPCA analysis module 'cell-type-consensus'"
LABEL org.opencontainers.image.authors="OpenScPCA [email protected]"
LABEL org.opencontainers.image.source="https://github.com/AlexsLemonade/OpenScPCA-analysis/tree/main/templates/analysis-module"
LABEL org.opencontainers.image.source="https://github.com/AlexsLemonade/OpenScPCA-analysis/tree/main/analyses/cell-type-consensus"

# Set an environment variable to allow checking if we are in an OpenScPCA container
ENV OPENSCPCA_DOCKER=TRUE

# Disable the renv cache to install packages directly into the R library
ENV RENV_CONFIG_CACHE_ENABLED=FALSE

# Install dependencies for renv library
RUN apt-get -y update && \
DEBIAN_FRONTEND=noninteractive \
apt-get install --no-install-recommends -y \
pandoc \
&& rm -rf /var/lib/apt/lists/*

# Install renv to enable later package installation
RUN Rscript -e "install.packages('renv')"

# Copy the renv.lock file from the host environment to the image
COPY renv.lock renv.lock

# Temporarily install Rhtslib separately
RUN Rscript -e 'BiocManager::install("Rhtslib")'

# restore from renv.lock file and clean up to reduce image size
RUN Rscript -e 'renv::restore()' && \
rm -rf ~/.cache/R/renv && \
rm -rf /tmp/downloaded_packages && \
rm -rf /tmp/Rtmp*

# Set CMD to bash to activate the environment for any commands
CMD ["/bin/bash"]
Loading
Loading