Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sample::developmental_stage field support #3425

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add Sample::developmental_stage field support #3425

merged 1 commit into from
Oct 23, 2023

Conversation

arkid15r
Copy link
Contributor

Issue Number

Resolves #3306

Purpose/Implementation Notes

Add developmental_stage to the Sample model and related serializers.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@arkid15r arkid15r requested a review from davidsmejia October 18, 2023 21:53
davidsmejia
davidsmejia approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r merged commit e34095d into dev Oct 23, 2023
17 of 18 checks passed
@arkid15r arkid15r deleted the ark/3306-sample-developmental-stage branch October 23, 2023 15:45
@arkid15r arkid15r mentioned this pull request Oct 24, 2023
Open
@davidsmejia davidsmejia mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add developmental stage attribute to sample
2 participants
@arkid15r @davidsmejia