Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API Backend Skeleton #280

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Create API Backend Skeleton #280

merged 8 commits into from
Oct 15, 2024

Conversation

zdeveloper
Copy link
Collaborator

@zdeveloper zdeveloper commented Oct 2, 2024

Description

Creates the backend skeleton for the API

Screenshots (if applicable)

N/A (it's a JSON API)

Related Issues

#260

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

@arinkulshi-skylight arinkulshi-skylight linked an issue Oct 8, 2024 that may be closed by this pull request
5 tasks
@schreiaj schreiaj marked this pull request as ready for review October 11, 2024 18:32
@schreiaj schreiaj changed the title [draft] backend skeleton Create API Backend Skeleton Oct 11, 2024
//base 64 image
private String templateImage;
//json array
private String shapes;
Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@column(columnDefinition = "jsonb") for explicit native JSON Storage in PostgreSQL

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zedd and I discussed this, stuck with String until such a time as we have a reason to change it. His primary concern was that jsonb columns will force a check that it's valid JSON and we may not need this. I have a hunch that it's something we'll end up wanting but that can be a migration when we need it (likely in #266) rather than have to sort it all out ahead of time.


import java.util.UUID;

public interface UploadRepository extends JpaRepository<Upload, UUID> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schreiaj schreiaj added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit c480e29 Oct 15, 2024
1 check passed
@schreiaj schreiaj deleted the zedd/backend-skeleton branch October 15, 2024 17:14
schreiaj added a commit that referenced this pull request Oct 15, 2024
* adding backend skeleton

* use uuid for id

* remove unused sequence

* Pass at moving the models outlined in dev meeting into SpringBoot

TODO: Write Migrations
TODO: Sort out auto generation of timestamps
TODO: Relationships aren't set up properly

* update ids to UUID

* added liquibase migration

* added liquibase migration

* Added some TODO items based on discussion with Arin

Created Upload Repository

---------

Co-authored-by: Andrew Schreiber <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2024
* Add box to currently editing field

* Add box highlighting currently edited field

* fix(285): Fix sidenav width and nav links (#295)

* Create API Backend Skeleton (#280)

* adding backend skeleton

* use uuid for id

* remove unused sequence

* Pass at moving the models outlined in dev meeting into SpringBoot

TODO: Write Migrations
TODO: Sort out auto generation of timestamps
TODO: Relationships aren't set up properly

* update ids to UUID

* added liquibase migration

* added liquibase migration

* Added some TODO items based on discussion with Arin

Created Upload Repository

---------

Co-authored-by: Andrew Schreiber <[email protected]>

* Add box to currently editing field

---------

Co-authored-by: knguyenrise8 <[email protected]>
Co-authored-by: Zedd Shmais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ReportVision Backend API skeleton
3 participants