Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-simulation summaries #32

Merged
merged 15 commits into from
Dec 18, 2024
Merged

Multi-simulation summaries #32

merged 15 commits into from
Dec 18, 2024

Conversation

afmagee42
Copy link
Contributor

@afmagee42 afmagee42 commented Dec 17, 2024

This PR

I have put all summarizing functionality into the submodule ringvax.summary.

@afmagee42 afmagee42 mentioned this pull request Dec 18, 2024
@afmagee42 afmagee42 marked this pull request as ready for review December 18, 2024 15:41
@afmagee42 afmagee42 requested a review from swo December 18, 2024 15:42
@afmagee42
Copy link
Contributor Author

NB: I still see this as conceptually gated on #28, which would lead to changes in ringvax.summary.prob_control_by_gen() and ringvax.summary.get_outbreak_size_df()

Copy link
Contributor

@swo swo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

Some small notes on presentation, which we could discuss/fix in this PR, and then some larger questions about computation and interfaces, which we might want to break off into other issues

Categorizing my review as "comment" so we can make sure to generate new issues before closing this PR

ringvax/app.py Show resolved Hide resolved
ringvax/app.py Outdated Show resolved Hide resolved
ringvax/app.py Show resolved Hide resolved
ringvax/app.py Outdated Show resolved Hide resolved
ringvax/app.py Show resolved Hide resolved
ringvax/app.py Show resolved Hide resolved
ringvax/summary.py Outdated Show resolved Hide resolved
@afmagee42 afmagee42 requested a review from swo December 18, 2024 18:08
Copy link
Contributor

@swo swo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There are easy ways to format percents; use as you like

ringvax/app.py Outdated Show resolved Hide resolved
ringvax/app.py Show resolved Hide resolved
Co-authored-by: Scott Olesen <[email protected]>
@afmagee42 afmagee42 merged commit d436c06 into main Dec 18, 2024
2 checks passed
@afmagee42 afmagee42 deleted the afm-viz-1 branch December 18, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate simulation-level output
2 participants