-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-simulation summaries #32
Conversation
NB: I still see this as conceptually gated on #28, which would lead to changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool!
Some small notes on presentation, which we could discuss/fix in this PR, and then some larger questions about computation and interfaces, which we might want to break off into other issues
Categorizing my review as "comment" so we can make sure to generate new issues before closing this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There are easy ways to format percents; use as you like
Co-authored-by: Scott Olesen <[email protected]>
This PR
I have put all summarizing functionality into the submodule
ringvax.summary
.